0000129: Use of external functions alone does not cause module to be linked

(0000402)
administrator (administrator)
2000-06-05 09:40

Xavier Leroy writes:
> > I've run into what seems to be a small bug.
> > It appears that if you use a "external" function from a library,
> > without using any other normal values (like regular functions) from
> > that library, the O'Caml linker does not include that library's
> > auto-link C libraries in the final link, preventing the executable
> > from being built.
>
> Right, this is a bug. It is fixed in the working sources. If you
> wish to test the fix, a patch is appended below.

This worked perfectly for me.

> Thanks for the bug report,

You are welcome!

> - Xavier Leroy

Thanks!
--
T. Kurt Bond, tkb@tkb.mpl.com

(0000403)
administrator (administrator)
2000-06-05 14:28

> I've run into what seems to be a small bug.
> It appears that if you use a "external" function from a library,
> without using any other normal values (like regular functions) from
> that library, the O'Caml linker does not include that library's
> auto-link C libraries in the final link, preventing the executable
> from being built.

Right, this is a bug. It is fixed in the working sources. If you
wish to test the fix, a patch is appended below.

Thanks for the bug report,

- Xavier Leroy

Index: csl/bytecomp/bytelink.ml
diff -u csl/bytecomp/bytelink.ml:1.55 csl/bytecomp/bytelink.ml:1.56
--- csl/bytecomp/bytelink.ml:1.55 Thu Apr 20 16:39:01 2000
+++ csl/bytecomp/bytelink.ml Mon Jun 5 14:19:50 2000
@@ -10,7 +10,7 @@
(* *)
(***********************************************************************)

-(* $Id: bytelink.ml,v 1.55 2000/04/20 14:39:01 doligez Exp $ *)
+(* $Id: bytelink.ml,v 1.56 2000/06/05 12:19:50 xleroy Exp $ *)

(* Link a set of .cmo files and produce a bytecode executable. *)

@@ -129,6 +129,7 @@
       seek_in ic pos_toc;
       let toc = (input_value ic : library) in
       close_in ic;
+ add_ccobjs toc;
       let required =
         List.fold_right
           (fun compunit reqd ->
@@ -142,7 +143,6 @@
             end else
               reqd)
           toc.lib_units [] in
- if required <> [] then add_ccobjs toc;
       Link_archive(file_name, required) :: tolink
     end
     else raise(Error(Not_an_object_file file_name))

(0000404)
administrator (administrator)
2000-06-05 14:38

Fixed on 2000-06-05 by Xavier

Issue History
Date Modified	Username	Field	Change
2005-11-18 10:13	administrator	New Issue

Notes
(0000402) administrator (administrator) 2000-06-05 09:40	Xavier Leroy writes: > > I've run into what seems to be a small bug. > > It appears that if you use a "external" function from a library, > > without using any other normal values (like regular functions) from > > that library, the O'Caml linker does not include that library's > > auto-link C libraries in the final link, preventing the executable > > from being built. > > Right, this is a bug. It is fixed in the working sources. If you > wish to test the fix, a patch is appended below. This worked perfectly for me. > Thanks for the bug report, You are welcome! > - Xavier Leroy Thanks! -- T. Kurt Bond, tkb@tkb.mpl.com

(0000403) administrator (administrator) 2000-06-05 14:28	> I've run into what seems to be a small bug. > It appears that if you use a "external" function from a library, > without using any other normal values (like regular functions) from > that library, the O'Caml linker does not include that library's > auto-link C libraries in the final link, preventing the executable > from being built. Right, this is a bug. It is fixed in the working sources. If you wish to test the fix, a patch is appended below. Thanks for the bug report, - Xavier Leroy Index: csl/bytecomp/bytelink.ml diff -u csl/bytecomp/bytelink.ml:1.55 csl/bytecomp/bytelink.ml:1.56 --- csl/bytecomp/bytelink.ml:1.55 Thu Apr 20 16:39:01 2000 +++ csl/bytecomp/bytelink.ml Mon Jun 5 14:19:50 2000 @@ -10,7 +10,7 @@ (* ) (*********************************************************************) -( $Id: bytelink.ml,v 1.55 2000/04/20 14:39:01 doligez Exp $ ) +( $Id: bytelink.ml,v 1.56 2000/06/05 12:19:50 xleroy Exp $ ) ( Link a set of .cmo files and produce a bytecode executable. *) @@ -129,6 +129,7 @@ seek_in ic pos_toc; let toc = (input_value ic : library) in close_in ic; + add_ccobjs toc; let required = List.fold_right (fun compunit reqd -> @@ -142,7 +143,6 @@ end else reqd) toc.lib_units [] in - if required <> [] then add_ccobjs toc; Link_archive(file_name, required) :: tolink end else raise(Error(Not_an_object_file file_name))

(0000404) administrator (administrator) 2000-06-05 14:38	Fixed on 2000-06-05 by Xavier

Relationships