Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

|| should be && in test/bdd.ml #8114

Closed
vicuna opened this issue Apr 19, 2003 · 1 comment
Closed

|| should be && in test/bdd.ml #8114

vicuna opened this issue Apr 19, 2003 · 1 comment
Labels

Comments

@vicuna
Copy link

vicuna commented Apr 19, 2003

Original bug ID: 1648
Reporter: administrator
Status: closed
Resolution: fixed
Priority: normal
Severity: minor
Category: ~DO NOT USE (was: OCaml general)

Bug description

In test/bdd.ml, I think

let succeeded = ref true in
for i = 1 to ntests do
succeeded := !succeeded || (* Look here! *) test_hwb bdd (random_vars n)
done;

should instead read

let succeeded = ref true in
for i = 1 to ntests do
succeeded := !succeeded && test_hwb bdd (random_vars n)
done;

otherwise "test_hwb" never gets called and the script is guaranteed to
print "OK" any time it doesn't fail.

Unfortunately, if I make this change, the script does fail when it
references an array out of bounds.

--
Tim Freeman tim@fungible.com
Which is worse: ignorance or apathy? Who knows? Who cares?
GPG public key fingerprint ECDF 46F8 3B80 BB9E 575D 7180 76DF FE00 34B1 5C78

@vicuna
Copy link
Author

vicuna commented Jul 16, 2003

Comment author: administrator

fixed by DD on 2003-07-16

@vicuna vicuna closed this as completed Jul 16, 2003
@vicuna vicuna added the bug label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant