Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFE: Export Reloc.str_item and add Pcaml.reloc_str_item #8365

Closed
vicuna opened this issue Nov 11, 2003 · 5 comments
Closed

RFE: Export Reloc.str_item and add Pcaml.reloc_str_item #8365

vicuna opened this issue Nov 11, 2003 · 5 comments
Labels
feature-wish

Comments

@vicuna
Copy link

vicuna commented Nov 11, 2003

Original bug ID: 1924
Reporter: administrator
Status: closed
Resolution: fixed
Priority: normal
Severity: feature
Category: ~DO NOT USE (was: OCaml general)

Bug description

Full_Name: Aleksey Nogin
Version: 3.07
OS: Red Hat Linux
Submission from: mojave1.cs.caltech.edu (131.215.44.186)

The Reloc module in camlp4 implements the "relocation" functionality of all the
MLast types, but only Reloc.expr and Reloc.patt are exported in the Reloc
interface (and re-exported as Pcaml.reloc_expr and Pcaml.reloc_patt). It would
be really nice if all the reloc functions were exported. In particular, our
project (MetaPRL - http://metaprl.org/) would benefit from being able to reloc
str_items (without having to re-implement this ourselves and update it for every
new OCaml release). Thanks!
@vicuna
Copy link
Author

vicuna commented Jul 7, 2004

Comment author: administrator

Thanks a lot for implementing this RFE!

Just wanted to let you know - while your comment on that entry said
"Done (all reloc funs exported)", it seems that Reloc.ctyp and
Reloc.row_field (and may be others) were missed and not exported.

--
Aleksey Nogin

Home Page: http://nogin.org/
E-Mail: nogin@cs.caltech.edu (office), aleksey@nogin.org (personal)
Office: Jorgensen 70, tel: (626) 395-2907

@vicuna
Copy link
Author

vicuna commented Jul 8, 2004

Comment author: administrator

Just wanted to let you know - while your comment on that entry said
"Done (all reloc funs exported)", it seems that Reloc.ctyp and
Reloc.row_field (and may be others) were missed and not exported.

Right: I forgot 3 of them. Fixed.

-- Michel

@vicuna
Copy link
Author

vicuna commented Jul 8, 2004

Comment author: administrator

Done (all reloc funs exported) by MM on 2004-06-24. More on 2004-07-08.

@vicuna vicuna closed this as completed Jul 8, 2004
@vicuna
Copy link
Author

vicuna commented Jul 12, 2004

Comment author: administrator

On 08.07.2004 01:54, Michel Mauny wrote:

Just wanted to let you know - while your comment on that entry said
"Done (all reloc funs exported)", it seems that Reloc.ctyp and
Reloc.row_field (and may be others) were missed and not exported.

Right: I forgot 3 of them. Fixed.

Thanks!

I am sorry to keep bugging you with these trivial issues, but as far as
I can tell, only reloc.mli was updated and pcaml re-exporting was not
added for them? Was that intentional?

--
Aleksey Nogin

Home Page: http://nogin.org/
E-Mail: nogin@cs.caltech.edu (office), aleksey@nogin.org (personal)
Office: Jorgensen 70, tel: (626) 395-2907

@vicuna
Copy link
Author

vicuna commented Jul 12, 2004

Comment author: administrator

nogin@cs.caltech.edu wrote/écrivait (Mon, Jul 12, 2004 at 11:02:52PM +0200):

I am sorry to keep bugging you with these trivial issues, but as far as
I can tell, only reloc.mli was updated and pcaml re-exporting was not
added for them? Was that intentional?

No problem. My mistake, again. Should be completely fixed, now. Sorry
about that,

-- Michel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-wish
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vicuna