Original bug ID: 204
Reporter: administrator
Status: closed
Resolution: fixed
Priority: normal
Severity: minor
Category: ~DO NOT USE (was: OCaml general)

Bug description

Full_Name: Pierre Crégut
Version: 3.00 and earlier
OS:
Submission from: machine107.cnet.fr (193.49.124.107)

If connect fails in [ThreadUnix.open_connection] then the locally created socket

is lost but not closed. This consumes descriptors.

let open_connection sockaddr =
let domain =
match sockaddr with
ADDR_UNIX _ -> PF_UNIX
| ADDR_INET (_, _) -> PF_INET
in
let sock = socket domain SOCK_STREAM 0 in
try
connect sock sockaddr; in_channel_of_descr sock, out_channel_of_descr sock

with e -> close socket; raise e (* <--- *)

A similar treatment is probably needed for [establish_server]