Original bug ID: 371
Reporter: administrator
Status: closed
Resolution: fixed
Priority: normal
Severity: minor
Category: -for CamlIDL use https://github.com/xavierleroy/camlidl/issues

Bug description

Full_Name: Dmitry Bely
Version: 3.01
OS: Windows NT 4.0
Submission from: d210.p3.col.ru (195.210.132.210)

Here is the bug description. Let's consider the following example:

--- test.idl ---
[
object
]
interface IX: IUnknown
{
HRESULT something();
}

[
object,
pointer_default(ref)
]
interface IY: IUnknown
{
HRESULT_bool getBool();
HRESULT_bool getIX( [out] IX **p );
}
--- end of test.idl ---

$ camlidl -header test.idl
test.idl

$ ocamlc -ccopt /Zi -c -ccopt test.c

test.c
test.h(43) : error C2061: syntax error : identifier 'HRESULT_bool'
...

$ ocamlc -ccopt /Zi -c -ccopt /DHRESULT_bool=HRESULT test.c

test.c
test.c(76) : warning C4047: 'function' : 'long ' differs in levels of
indirection from 'long *'
test.c(76) : warning C4024: 'camlidl_c2ml_Com_HRESULT_bool' : different types
for formal and actual parameter 1
test.c(76) : warning C4020: 'camlidl_c2ml_Com_HRESULT_bool' : too many actual
parameters
test.c(100) : warning C4047: 'function' : 'long ' differs in levels of
indirection from 'long *'
test.c(100) : warning C4024: 'camlidl_c2ml_Com_HRESULT_bool' : different types
for formal and actual parameter 1
test.c(100) : warning C4020: 'camlidl_c2ml_Com_HRESULT_bool' : too many actual
parameters
test.c(126) : warning C4020: 'camlidl_ml2c_Com_HRESULT_bool' : too many actual
parameters
test.c(147) : warning C4020: 'camlidl_ml2c_Com_HRESULT_bool' : too many actual
parameters

So the following bugs are obvious:

1. HRESULT_bool (and HRESULT_int) definition is missed in camlidlruntime.h
   (or camlidl compiler should always generate code with HRESULT instead of them)

2. The way compiler uses camlidl_c2ml_Com_HRESULT_bool() and
   camlidl_ml2c_Com_HRESULT_bool() does not conform to their
   definition. Specifically, the generated code implies some context structure
   parameter while camlidl_*_Com_HRESULT_bool() definitions have no idea about
   it.