0004245: Integer conversions do not detect overflow in corner cases

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0004245

OCaml

OCaml general

public

2007-03-29 16:12

2011-05-29 12:14

Reporter

mottl

Assigned To

xleroy

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

3.09.3

Target Version

Fixed in Version

3.12.0+dev

Summary

0004245: Integer conversions do not detect overflow in corner cases

Description

This should not be accepted:

  # Int32.of_string "2147483648";;
  - : int32 = -2147483648l

This is correctly rejected (first number + 1):

  # Int32.of_string "2147483649";;
  Exception: Failure "int_of_string".

And this is correctly accepted (first number - 1):

  # Int32.of_string "2147483647";;
  - : int32 = 2147483647l

The corner case is obviously not handled correctly.

The same problem happens with the other integer conversions: Int64.of_string, Nativeint.of_string, and even int_of_string.

Tags

No tags attached.

Attached Files

Relationships

duplicate of	0004210	closed	xleroy	little bug in int_of_string
related to	0003302	closed		Int64.of_string does not detect overflow from positive to negative ints

Notes
(0003995) oandrieu (reporter) 2007-03-29 16:37	> The corner case is obviously not handled correctly. actually, that's on purpose, cf. Xavier's comments in bug 0004210

(0005025) xleroy (administrator) 2009-07-15 16:56	See comments on PR#4210

Issue History
Date Modified	Username	Field	Change
2007-03-29 16:12	mottl	New Issue
2007-03-29 16:37	oandrieu	Note Added: 0003995
2007-04-03 18:00	doligez	Relationship added	duplicate of 0004210
2007-04-03 18:01	doligez	Severity	major => minor
2007-04-03 18:01	doligez	Status	new => closed
2007-04-03 18:01	doligez	Resolution	open => won't fix
2009-07-15 16:56	xleroy	Note Added: 0005025
2009-07-15 16:56	xleroy	Status	closed => resolved
2009-07-15 16:56	xleroy	Resolution	won't fix => fixed
2009-07-15 16:56	xleroy	Fixed in Version	=> 3.12.0+dev
2009-07-15 16:58	xleroy	Assigned To	=> xleroy
2009-08-28 11:28	xleroy	Relationship added	related to 0003302
2011-05-29 12:14	xleroy	Status	resolved => closed