0004302: fail to parse list comprehension

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0004302

OCaml

Camlp4

public

2007-05-25 17:50

2010-04-29 14:26

Reporter

hirokawa

Assigned To

ertai

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

3.10.0

Target Version

Fixed in Version

3.10+dev

Summary

0004302: fail to parse list comprehension

Description

Camlp4ListComprehension.ml fails to parse the code:

# [ x | x <- []; not x; y <- [] ];;
Parse error: [item] expected after ";" (in [comprehension_or_sem_expr_for_list])

This is because test_patt_lessminus mishandles ";".
(I did not realize this bug when I submitted the file. Sorry.)

Here is a patch:

Camlp4ListComprehension.ml, line 52:
- | Some (KEYWORD ("as" | "::" | ";" | "," | "_"))
+ | Some (KEYWORD ("as" | "::" | "," | "_"))

Tags

No tags attached.

Attached Files

Relationships

Notes
(0004078) ertai (developer) 2007-05-27 18:37	Thank you, fixed in CVS.

Issue History
Date Modified	Username	Field	Change
2007-05-25 17:50	hirokawa	New Issue
2007-05-27 18:37	ertai	Note Added: 0004078
2007-05-27 18:37	ertai	Assigned To	=> ertai
2007-05-27 18:37	ertai	Status	new => resolved
2007-05-27 18:37	ertai	Resolution	open => fixed
2007-05-27 18:37	ertai	Fixed in Version	=> 3.10+dev
2010-04-29 14:26	xleroy	Status	resolved => closed