Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail to parse list comprehension #4302

Closed
vicuna opened this issue May 25, 2007 · 1 comment
Closed

fail to parse list comprehension #4302

vicuna opened this issue May 25, 2007 · 1 comment

Comments

@vicuna
Copy link

vicuna commented May 25, 2007

Original bug ID: 4302
Reporter: hirokawa
Assigned to: ertai
Status: closed (set by @xavierleroy on 2010-04-29T12:26:23Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 3.10.0
Fixed in version: 3.10+dev
Category: -for Camlp4 use https://github.com/ocaml/camlp4/issues
Monitored by: hirokawa

Bug description

Camlp4ListComprehension.ml fails to parse the code:

[ x | x <- []; not x; y <- [] ];;

Parse error: [item] expected after ";" (in [comprehension_or_sem_expr_for_list])

This is because test_patt_lessminus mishandles ";".
(I did not realize this bug when I submitted the file. Sorry.)

Here is a patch:

Camlp4ListComprehension.ml, line 52:

  •      | Some (KEYWORD ("as" | "::" | ";" | "," | "_"))
    
  •      | Some (KEYWORD ("as" | "::" | "," | "_"))
    
@vicuna
Copy link
Author

vicuna commented May 27, 2007

Comment author: ertai

Thank you, fixed in CVS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant