Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small bug in Win32 version of Unix #4397

Closed
vicuna opened this issue Sep 19, 2007 · 1 comment
Closed

small bug in Win32 version of Unix #4397

vicuna opened this issue Sep 19, 2007 · 1 comment
Labels
bug

Comments

@vicuna
Copy link

vicuna commented Sep 19, 2007

Original bug ID: 4397
Reporter: @oandrieu
Status: closed (set by @xavierleroy on 2007-10-25T07:44:06Z)
Resolution: fixed
Priority: normal
Severity: minor
Platform: i386
OS: Windows XP
Version: 3.10.0
Category: ~DO NOT USE (was: OCaml general)
Related to: #4431

Bug description

in otherlibs/win32unix/open.c the open_access_flags and open_create_flags arrays are declared with a size of 8 but the OCaml variant in unix.ml has size 12.

Also, the documentation of Unix could mention that not all flags are supported (O_APPEND notably).
@vicuna
Copy link
Author

vicuna commented Oct 25, 2007

Comment author: @xavierleroy

Fixed the size of the arrays in 3.10 release branch.

As for O_APPEND, it seems possible to support it by giving the right flags to CreateFile. I'll file a separate PR for this.

@vicuna vicuna closed this as completed Oct 25, 2007
@vicuna vicuna mentioned this issue Mar 14, 2019
Closed
@vicuna vicuna added the bug label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vicuna