0004543: Patch implementing toplevel phrase filters

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0004543

OCaml

Camlp4

public

2008-04-28 01:29

2010-04-29 14:31

Reporter

Martin Jambon

Assigned To

ertai

Priority

normal

Severity

feature

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

3.11+dev

Summary

0004543: Patch implementing toplevel phrase filters

Description

The idea is to provide the possibility of using filters in the toplevel. This feature is crucial for a clean port of micmatch to 3.10. It works by adding a new class of filters: toplevel phrase filters.

The issue of filtering str_items in the toplevel was raised in this caml-list thread:

http://caml.inria.fr/pub/ml-archives/caml-list/2008/04/80773c9b3c6420d066c98f1a9a27f70e.en.html [^]

So I'm sending a little patch with some sample code for testing.
It's quite simple and I hope I haven't overlooked any big issue.

Tags

No tags attached.

Attached Files

topphrase_filter.tar.gz [^] (1,414 bytes) 2008-04-28 01:29

Relationships

Notes
(0004501) ertai (developer) 2008-04-28 13:35	Nice, I have not checked it for now but if it's ok it will be part of the next release.

(0004687) Martin Jambon (reporter) 2008-10-26 11:46	I see that it's not included in 3.11.0+beta1. Please take a look, it's important.

(0004688) ertai (developer) 2008-10-27 14:50	Thanks for the patch and your patience, it's now applied in the CVS (head and release311). Moreover you've nicely and simply solved this issue by adding a new registration function. This way the user can choose the semantics. Thanks!

Issue History
Date Modified	Username	Field	Change
2008-04-28 01:29	Martin Jambon	New Issue
2008-04-28 01:29	Martin Jambon	File Added: topphrase_filter.tar.gz
2008-04-28 13:35	ertai	Note Added: 0004501
2008-04-28 13:35	ertai	Assigned To	=> ertai
2008-04-28 13:35	ertai	Status	new => assigned
2008-10-26 11:46	Martin Jambon	Note Added: 0004687
2008-10-27 14:50	ertai	Note Added: 0004688
2008-10-27 14:50	ertai	Status	assigned => resolved
2008-10-27 14:50	ertai	Resolution	open => fixed
2008-10-27 14:50	ertai	Product Version	3.11+dev =>
2008-10-27 14:50	ertai	Fixed in Version	=> 3.11+dev
2010-04-29 14:31	xleroy	Status	resolved => closed