0004598: Loc.to_string: bad support for multiple lines

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0004598

OCaml

Camlp4

public

2008-08-14 15:26

2012-09-17 11:57

Reporter

Christophe Troestler

Assigned To

doligez

Priority

normal

Severity

minor

Reproducibility

always

Status

assigned

Resolution

open

Platform

OS Version

Product Version

3.10.3+dev

Target Version

4.00.2+dev

Fixed in Version

Summary

0004598: Loc.to_string: bad support for multiple lines

Description

When the location extends several lines, the format used by Loc.to_string is not compatible with the way Emacs parses locations, it should be of the form

  File "xxx", line 12-13, characters 34-23:

The following code maybe shows better what I mean

  let (fname, line0, bol0, off0, line1, bol1, off1, _) = Loc.to_tuple loc in
  let line =
    if line0 = line1 then sprintf "%i" line0
    else sprintf "%i-%i" line0 line1 in
  sprintf "File \"%s\", line %s, characters %i-%i"
    fname line (off0 - bol0) (off1 - bol1)

Tags

No tags attached.

Attached Files

Relationships

related to

0004659

resolved

frisch

wrong error message (parser seems to interpret many lines as one line) (3.10.2 and 3.10.0)

Notes
(0004597) doligez (manager) 2008-09-04 17:31	That's because the Emacs guys changed their parsing code without warning us. We'll make it compatible at some point, but we will also need to change our emacs-lisp code, so it won't be that easy.

Issue History
Date Modified	Username	Field	Change
2008-08-14 15:26	Christophe Troestler	New Issue
2008-09-04 17:31	doligez	Note Added: 0004597
2008-09-04 17:31	doligez	Status	new => acknowledged
2012-07-11 15:03	doligez	Relationship added	related to 0004659
2012-07-11 15:03	doligez	Target Version	=> 4.01.0+dev
2012-07-31 13:36	doligez	Target Version	4.01.0+dev => 4.00.1+dev
2012-09-17 11:57	doligez	Assigned To	=> doligez
2012-09-17 11:57	doligez	Status	acknowledged => assigned
2012-09-17 11:57	doligez	Target Version	4.00.1+dev => 4.00.2+dev