0004673: camlp4 fails to preprocess correctly valid object oriented OCaml

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0004673

OCaml

Camlp4

public

2008-12-16 19:55

2012-09-25 20:06

Reporter

avaron

Assigned To

xclerc

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

3.11.0+beta

Target Version

Fixed in Version

3.12.1+dev

Summary

0004673: camlp4 fails to preprocess correctly valid object oriented OCaml

Description

The following tiny file:

-----------------
(* test.ml *)

class test (x : int) = object
    val a = x;
    val b = x;
    method clone = ({< a = x; b = x>})
end
--------------

compiles correctly with OCaml 3.10.2, OCaml 3.11.0, and when the preprocessor is camlp4 3.10.2.

However, when the preprocessors is camlp4 3.11.0 it fails:

samson:~ andres$ ocamlc -pp 'camlp4orf pa_extend.cmo' test.ml
File "test.ml", line 4, characters 27-28:
Warning S: this expression should have type unit.
File "test.ml", line 4, characters 30-35:
Error: This expression has type bool but is here used with type int

The problem is the {< ...; .... >} which is valid. A single assignment as in {< x = 4 >} would be preprocessed correctly.

Tags

No tags attached.

Attached Files

Camlp4OCamlRevisedParser.ml.diff [^] (907 bytes) 2009-06-01 16:21 [Show Content] [Hide Content]

diff -u ocaml-3.11.0+rc1/camlp4/Camlp4Parsers/Camlp4OCamlRevisedParser.ml ocaml-3.11.0+rc1-bugfix/camlp4/Camlp4Parsers/Camlp4OCamlRevisedParser.ml
--- ocaml-3.11.0+rc1/camlp4/Camlp4Parsers/Camlp4OCamlRevisedParser.ml	2008-10-27 15:03:56.000000000 +0100
+++ ocaml-3.11.0+rc1-bugfix/camlp4/Camlp4Parsers/Camlp4OCamlRevisedParser.ml	2009-06-01 13:03:37.000000000 +0200
@@ -1387,7 +1387,7 @@
             <:rec_binding< $anti:mk_anti ~c:"rec_binding" n s$ >>
         | `ANTIQUOT ("list" as n) s ->
             <:rec_binding< $anti:mk_anti ~c:"rec_binding" n s$ >>
-        | l = label; "="; e = expr -> <:rec_binding< $lid:l$ = $e$ >> ] ]
+        | l = label; "="; e = expr LEVEL "top" -> <:rec_binding< $lid:l$ = $e$ >> ] ]
     ;
     meth_list:
       [ [ m = meth_decl; ";"; (ml, v) = SELF  -> (<:ctyp< $m$; $ml$ >>, v)
Only in ocaml-3.11.0+rc1-bugfix/camlp4/Camlp4Parsers/: Camlp4OCamlRevisedParser.ml~

Relationships

duplicate of

0005144

closed

xclerc

object copy syntax parsed wrong with camlp4of

Notes
(0004802) avaron (reporter) 2008-12-16 20:03	The following is the way camlp4 is interpreting the class definition: samson:~ andres$ camlp4orf pr_r.cmo test.ml class test (x : int) = object value a = x; value b = x; method clone = {< a = (x; b = x); >}; end;

(0004978) bluestorm (reporter) 2009-06-01 16:20	I attached a tentative bugfix, wich I also uploaded at http://bluestorm.info/camlp4/objcopy-fix/Camlp4OCamlRevisedParser.ml.diff [^] I also wrote a small extension for a quick workaround : http://bluestorm.info/camlp4/objcopy-fix/list.php [^]

(0005805) xclerc (developer) 2011-02-15 11:56	Provided patch tested and applied -- thanks.

Issue History
Date Modified	Username	Field	Change
2008-12-16 19:55	avaron	New Issue
2008-12-16 20:03	avaron	Note Added: 0004802
2009-03-31 13:41	xleroy	Status	new => assigned
2009-03-31 13:41	xleroy	Assigned To	=> ertai
2009-06-01 16:20	bluestorm	Note Added: 0004978
2009-06-01 16:21	bluestorm	File Added: Camlp4OCamlRevisedParser.ml.diff
2011-02-15 11:43	xclerc	Relationship added	duplicate of 0005144
2011-02-15 11:55	xclerc	Assigned To	ertai => xclerc
2011-02-15 11:56	xclerc	Note Added: 0005805
2011-02-15 11:56	xclerc	Status	assigned => resolved
2011-02-15 11:56	xclerc	Fixed in Version	=> 3.12.1+dev
2011-02-15 11:56	xclerc	Resolution	open => fixed
2012-09-25 20:06	xleroy	Status	resolved => closed