You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Original bug ID: 4710 Reporter: mwipliez Assigned to: ertai Status: closed (set by @xavierleroy on 2011-05-29T10:20:03Z) Resolution: fixed Priority: normal Severity: minor Version: 3.11.0 Fixed in version: 3.11.2+dev Category: -for ocamlbuild use https://github.com/ocaml/ocamlbuild/issues Monitored by:@ygrek mwipliez
Bug description
If you have a plug-in for Ocamlbuild on Windows, Ocamlbuild will re-build the plug-in every time you invoke it. This does not happen on Linux. It seems to me that this is due to the way Ocamlbuild evaluates the need to recompile the plugin.
In file plugin.ml, line 33, the value "we_have_a_plugin" is defined as follows:
let we_have_a_plugin = sys_file_exists (!Options.build_dir/plugin)
This is used line 55 to check whether the plugin should be rebuilt:
if a && b && c && we_have_a_plugin then
() (* Up to date *)
else...
But on Windows executables have the ".exe" extension, therefore I believe that "we_have_a_plugin" should be defined this way:
let we_have_a_plugin = sys_file_exists (!Options.build_dir/plugin) || sys_file_exists (!Options.build_dir/plugin ^ ".exe")
The text was updated successfully, but these errors were encountered:
Original bug ID: 4710
Reporter: mwipliez
Assigned to: ertai
Status: closed (set by @xavierleroy on 2011-05-29T10:20:03Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 3.11.0
Fixed in version: 3.11.2+dev
Category: -for ocamlbuild use https://github.com/ocaml/ocamlbuild/issues
Monitored by: @ygrek mwipliez
Bug description
If you have a plug-in for Ocamlbuild on Windows, Ocamlbuild will re-build the plug-in every time you invoke it. This does not happen on Linux. It seems to me that this is due to the way Ocamlbuild evaluates the need to recompile the plugin.
In file plugin.ml, line 33, the value "we_have_a_plugin" is defined as follows:
let we_have_a_plugin = sys_file_exists (!Options.build_dir/plugin)
This is used line 55 to check whether the plugin should be rebuilt:
if a && b && c && we_have_a_plugin then
() (* Up to date *)
else...
But on Windows executables have the ".exe" extension, therefore I believe that "we_have_a_plugin" should be defined this way:
let we_have_a_plugin = sys_file_exists (!Options.build_dir/plugin) || sys_file_exists (!Options.build_dir/plugin ^ ".exe")
The text was updated successfully, but these errors were encountered: