Comment author: @zoggy

Having an unterminated string in a comment is an ocaml error:

cat > t.ml

(* "coucou le commentaire avec une mauvaise chaine *)
let x = 1;;
^D

#ocaml t.ml
File "t.ml", line 1, characters 0-2:
Error: This comment contains an unterminated string literal

This is not an ocamldoc related problem. The error occurs when calling the ocaml parser.

Comment author: aostruszka

Applies to both ocamlc and camlp4 (3.11.2)

$ cat dupa.ml
(* Some " to be printed *)
let () = print_char '"'; print_newline ();;

$ ocamlc dupa.ml
File "dupa.ml", line 1, characters 0-2:
Error: Comment not terminated

$ ocamlc -pp camlp4o dupa.ml
File "dupa.ml", line 1, characters 0-71 (end at line 3, character 0):
Comment not terminated
File "dupa.ml", line 1, characters 0-1:
Error: Preprocessor error

Comment author: Camarade_Tux

This also lead to the disappearance of code sometimes. I just had a whole chunk of a file that disappeared because of that behaviour.

    Objective Caml version 3.12.0

(* a " a *)

let x = 42 in
(* b " b *)
x;;
Error: Unbound value x

Maybe that having lone " between (* and *) should be forbidden? Or at least, it could emit a warning. I hopefully had camlp4 parsing and also had to see the temp file instead of the source directly, but without that, I would probably have spent some time on this issue.

Comment author: @glondu

Having an unterminated string in a comment is an ocaml error [...]

Is this documented somewhere? I would expect it in section 6.1 ("Lexical conventions", paragraph "Comments"), but couldn't find mention of this even by grepping through the whole manual.

Comment author: @xavierleroy

I can't reproduce the crash with OCaml 4.00 dev. Closing this PR.

$ cat foo.ml
cat dupa.ml
(* Some " to be printed *)
let () = print_char '"'; print_newline ();;
$ ocamldoc foo.ml
File "foo.ml", line 2, characters 0-2:
Error: Comment not terminated
1 error(s) encountered