Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0004755OCamlOCaml windowspublic2009-03-25 15:022012-03-14 10:31
Reporterygrek 
Assigned To 
PrioritynormalSeverityfeatureReproducibilityalways
StatusresolvedResolutionsuspended 
PlatformOSWin32OS Version
Product Version3.11.0 
Target VersionFixed in Version 
Summary0004755: Graphics.resize_window is not implemented on win32
DescriptionCurrently it does nothing.
Patch below.
Additional Information--- D:\contrib\ocaml-cvs\ocaml\otherlibs\win32graph\open.c 2007-11-06 17:16:56.000000000 +0200
+++ open.c 2009-03-25 15:50:20.186082800 +0200
@@ -306,7 +306,7 @@
 {
   gr_check_open ();
 
- /* FIXME TODO implement this function... */
+ SetWindowPos( grwindow.hwnd, NULL, 0, 0, Int_val(vx), Int_val(vy), SWP_NOMOVE | SWP_NOZORDER);
 
   return Val_unit;
 }
TagsNo tags attached.
Attached Files

- Relationships

-  Notes
(0006899)
doligez (administrator)
2012-02-08 17:07

Thanks for the patch, but it has a few problems:

1. It fails to clear the graphics window after the resize.
2. It sets the wrong size: apparently Windows takes the given size to incude the borders and the title bar, while we expect the given size to be the content size.

BTW, open_graph has the same bug when the user specifies a size.
(0006904)
ygrek (reporter)
2012-02-09 16:11

I do not have access and desire to touch windows anymore, so I am hardly going to investigate this further, sorry.
(0006915)
Christophe Troestler (reporter)
2012-02-10 19:24

Since size_x() and size_y() return the size without the borders, it is possible to know how many pixels to add — probably computing this a single time when Graphics is loaded is enough? There may be a better solution though.
(0007071)
xleroy (administrator)
2012-03-14 10:31

No one on the OCaml dev team is motivated enough to work on this feature wish, so I'm putting it in the "suspended" state. If anyone is willing to work on it, an (improved) patch is welcome.

- Issue History
Date Modified Username Field Change
2009-03-25 15:02 ygrek New Issue
2009-04-29 15:43 doligez Status new => acknowledged
2012-02-08 17:07 doligez Note Added: 0006899
2012-02-08 17:07 doligez Severity trivial => minor
2012-02-08 17:07 doligez Status acknowledged => feedback
2012-02-09 16:11 ygrek Note Added: 0006904
2012-02-09 16:11 ygrek Status feedback => new
2012-02-10 19:24 Christophe Troestler Note Added: 0006915
2012-03-14 10:31 xleroy Note Added: 0007071
2012-03-14 10:31 xleroy Severity minor => feature
2012-03-14 10:31 xleroy Status new => resolved
2012-03-14 10:31 xleroy Resolution open => suspended
2012-03-14 10:31 xleroy Category OCaml general => OCaml windows
2012-03-14 10:31 xleroy OS => Win32


Copyright © 2000 - 2011 MantisBT Group
Powered by Mantis Bugtracker