0004796: yacc reader.c substring doesnt null terminate

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0004796

OCaml

OCaml general

public

2009-05-19 21:30

2009-05-20 13:57

Reporter

avsm

Assigned To

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

3.11.0

Target Version

Fixed in Version

3.11.1+dev

Summary

0004796: yacc reader.c substring doesnt null terminate

Description

We've had this patch in the OpenBSD port for a couple of years, and it's triggered with debug malloc flags which fill allocated memory with junk.

patch:
http://www.openbsd.org/cgi-bin/cvsweb/ports/lang/ocaml/patches/patch-yacc_reader_c?rev=1.2 [^]

--- yacc/reader.c.orig Thu Oct 6 07:34:51 2005
+++ yacc/reader.c Thu Nov 27 22:42:14 2008
@@ -163,6 +163,7 @@ char *substring (char *str, int start, int len)
   for (i = 0; i < len; i++){
     buf[i] = str[start+i];
   }
+ buf[i] = '\0';
   return buf;
}

Tags

No tags attached.

Attached Files

Relationships

Notes
(0004963) doligez (manager) 2009-05-20 13:57	Thanks for the report. Your patch will be included in 3.11.1

Issue History
Date Modified	Username	Field	Change
2009-05-19 21:30	avsm	New Issue
2009-05-20 13:57	doligez	Note Added: 0004963
2009-05-20 13:57	doligez	Status	new => closed
2009-05-20 13:57	doligez	Resolution	open => fixed
2009-05-20 13:57	doligez	Fixed in Version	=> 3.11.1+dev