Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variant types in chapter "18 Interfacing C with Objective Caml" #4803

Closed
vicuna opened this issue May 21, 2009 · 2 comments
Closed

Variant types in chapter "18 Interfacing C with Objective Caml" #4803

vicuna opened this issue May 21, 2009 · 2 comments

Comments

@vicuna
Copy link

vicuna commented May 21, 2009

Original bug ID: 4803
Reporter: gildor
Status: closed (set by @xavierleroy on 2010-05-14T08:25:55Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 3.11.0
Fixed in version: 3.12.0+dev
Category: documentation
Related to: #4753

Bug description

I think the subsection "18.3.6 Variants" is misnamed, since it is only talking about "Polymorphic variants". Renaming chapter to "18.3.6 Polymorphic variants" should be better.

Also a couple of simple examples for "18.3.4 Concrete types" should also be welcomed, to illustrate variant value:

Constructed term: None
Representation: Value_int(0); first constant constructor of None | Some int

Constructed term: Some 1234
Representation: Block with size = 1 and tag = 0; first non-constant constructor of None | Some int and first field contains Value_int(1234)

Thanks
Sylvain Le Gall

@vicuna
Copy link
Author

vicuna commented Apr 27, 2010

Comment author: @garrigue

Renamed chapter 18.3.6 to "Polymorphic variants" as suggested.

@vicuna
Copy link
Author

vicuna commented May 14, 2010

Comment author: @xavierleroy

Added a more detailed example in 18.3.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant