0004809: Windows: Unix.create_process not working properly from a Cygwin shell

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0004809

OCaml

OCaml general

public

2009-05-28 16:36

2009-06-03 10:45

Reporter

vouillon

Assigned To

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

3.11.0

Target Version

Fixed in Version

3.11.1+dev

Summary

0004809: Windows: Unix.create_process not working properly from a Cygwin shell

Description

When Unison is started from a Cygwin shell, it fails to start an ssh subprocess (calling Unix.create_process). The reason is that wrong startup information is passed to the ssh subprocess.

Changing the line:
    GetStartupInfo(&si);
to:
    ZeroMemory(&si, sizeof(STARTUPINFO));
    si.cb = sizeof(STARTUPINFO);
in file createprocess.c fixes the problem. By the way, this is what the Microsoft CRT library does.

At least, field si.cbReserved2 should be set to 0 and field si.lpReserved2 should be set to NULL, as documented at:
http://msdn.microsoft.com/en-us/library/ms686331(VS.85).aspx [^]

Tags

No tags attached.

Attached Files

Relationships

Notes
(0004979) xleroy (administrator) 2009-06-03 10:45	Thanks for pointing out this issue. The suggested fix was applied in the "release311" branch and will be part of release 3.11.1

Issue History
Date Modified	Username	Field	Change
2009-05-28 16:36	vouillon	New Issue
2009-06-03 10:45	xleroy	Note Added: 0004979
2009-06-03 10:45	xleroy	Status	new => closed
2009-06-03 10:45	xleroy	Resolution	open => fixed
2009-06-03 10:45	xleroy	Fixed in Version	=> 3.11.1+dev