Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlbrowser crashes when try editing comments "(* ... *)" #4814

Closed
vicuna opened this issue Jun 6, 2009 · 1 comment
Closed

ocamlbrowser crashes when try editing comments "(* ... *)" #4814

vicuna opened this issue Jun 6, 2009 · 1 comment
Labels
bug

Comments

@vicuna
Copy link

vicuna commented Jun 6, 2009

Original bug ID: 4814
Reporter: Maxim Sokhatsky
Status: closed (set by @garrigue on 2009-06-08T04:46:09Z)
Resolution: fixed
Priority: normal
Severity: crash
Version: 3.11.0
Fixed in version: 3.11.1+dev
Category: ~DO NOT USE (was: OCaml general)
Tags: ocamlbrowser

Bug description

Reproduce Steps:

  1. open ocamlbrowser
  2. select editor
  3. select *.ml file from
  4. select any non commented line
  5. place "(*" in previous line
  6. place "*)" in succ line

Result Issue: ocamlbrowser crashed in tk84.dll

OS: Windows Vista Business SP1
Ocaml Version: OCaml 3.11.0 for MINGW (downloaded from official INRIA site)
ActiveState Tcl/Tk Version: ActiveState ActiveTcl 8.4.19.1.286921

File attachments
@vicuna
Copy link
Author

vicuna commented Jun 8, 2009

Comment author: @garrigue

Fixed in CVS for 3.11.1.

Location.input_name shall always be "" when we are not parsing a file, otherwise Location tries to open it.
As a result, I wonder if setting it to "none" by default is really a good idea...

@vicuna vicuna closed this as completed Jun 8, 2009
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vicuna