Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move_start_p is partially used in Struct/Lexer.mll #4846

Closed
vicuna opened this issue Aug 14, 2009 · 5 comments
Closed

move_start_p is partially used in Struct/Lexer.mll #4846

vicuna opened this issue Aug 14, 2009 · 5 comments

Comments

@vicuna
Copy link

vicuna commented Aug 14, 2009

Original bug ID: 4846
Reporter: furuse
Assigned to: @bobzhang
Status: closed (set by @damiendoligez on 2015-01-09T18:20:35Z)
Resolution: suspended
Priority: normal
Severity: minor
Version: 3.11.1
Target version: undecided
Category: -for Camlp4 use https://github.com/ocaml/camlp4/issues
Related to: #4595
Monitored by: @bobzhang

Bug description

I have found a partial application of move_start_p at the line 302 of Camlp4/Struct/Lexer.mll.
I do not understand what the function is intended to do, but the code does nothing: clearly a bug.

@vicuna
Copy link
Author

vicuna commented Aug 17, 2009

Comment author: ertai

You are right, this partial application is right. But I don't if adding the 'c' argument would fix or break this code.

@vicuna
Copy link
Author

vicuna commented Aug 22, 2012

Comment author: @bobzhang

seems to be related to 4595

@vicuna
Copy link
Author

vicuna commented Jul 9, 2013

Comment author: @damiendoligez

I tried to add the missing c and it doesn't change the results of the test of 4595...

@vicuna
Copy link
Author

vicuna commented Jul 10, 2013

Comment author: @damiendoligez

We need to experiment more before we change this code. Postponing to 4.02.

@vicuna
Copy link
Author

vicuna commented Jan 9, 2015

Comment author: @damiendoligez

Transferred to camlp4/camlp4#67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant