0004855: camlp4 doesn't handle "-I +directory" notation for include directories

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0004855

OCaml

Camlp4

public

2009-09-02 13:31

2012-09-17 17:24

Reporter

Dmitry Grebeniuk

Assigned To

Priority

normal

Severity

minor

Reproducibility

always

Status

confirmed

Resolution

open

Platform

OS Version

Product Version

3.11.1

Target Version

4.00.2+dev

Fixed in Version

Summary

0004855: camlp4 doesn't handle "-I +directory" notation for include directories

Description

I'm using a syntax extension that installs to `ocamlc -where`/dir.
I've tried to use it with

  $ camlp4 ... -I +dir pa_someext.cmo ...

but with no success:

  Camlp4: Uncaught exception: DynLoader.Error ("pa_someext.cmo", "file not found in path")

However, ocamlc/ocamlopt does handle this correctly:

  $ ocamlc -I +dir pa_someext.cmo -o somebin

shows to me that pa_someext.cmo is found and processed.

Looking at camlp4 sources I've figured out why camlp4 doesn't handle +directory notation: function "include_dir" in "$ocamlsources/camlp4/Camlp4/Struct/DynLoader.ml" doesn't have any special processing of "+directory" syntax.

IMHO every ocaml-related tool (toplevel, compiler, preprocessor) should have the same semantics for -I option.

Tags

No tags attached.

Attached Files

p4_expand_directory.diff [^] (1,210 bytes) 2012-07-30 08:45 [Show Content] [Hide Content]

diff -r 973d50fe6fa4 camlp4/Camlp4Bin.ml
--- a/camlp4/Camlp4Bin.ml	Mon Jul 30 11:21:53 2012 +0800
+++ b/camlp4/Camlp4Bin.ml	Mon Jul 30 14:43:44 2012 +0800
@@ -236,7 +236,7 @@
   };
 
 value initial_spec_list =
-  [("-I", Arg.String (fun x -> input_file (IncludeDir x)),
+  [("-I", Arg.String (fun x -> input_file (IncludeDir (Camlp4_import.Misc.expand_directory Camlp4_config.ocaml_standard_library x))),
     "<directory>  Add directory in search patch for object files.");
   ("-where", Arg.Unit print_stdlib,
     "Print camlp4 library directory and exit.");
diff -r 973d50fe6fa4 camlp4/boot/camlp4boot.ml
--- a/camlp4/boot/camlp4boot.ml	Mon Jul 30 11:21:53 2012 +0800
+++ b/camlp4/boot/camlp4boot.ml	Mon Jul 30 14:43:44 2012 +0800
@@ -15704,7 +15704,7 @@
          !rcall_callback ())
       
     let initial_spec_list =
-      [ ("-I", (Arg.String (fun x -> input_file (IncludeDir x))),
+      [ ("-I", (Arg.String (fun x -> input_file (IncludeDir (Camlp4_import.Misc.expand_directory Camlp4_config.ocaml_standard_library x)))),
          "<directory>  Add directory in search patch for object files.");
         ("-where", (Arg.Unit print_stdlib),
          "Print camlp4 library directory and exit.");

Relationships

Notes
(0007831) furuse (reporter) 2012-07-30 08:45	I've attached a patch to fix this.

Issue History
Date Modified	Username	Field	Change
2009-09-02 13:31	Dmitry Grebeniuk	New Issue
2009-09-02 13:31	Dmitry Grebeniuk	Status	new => assigned
2009-09-02 13:31	Dmitry Grebeniuk	Assigned To	=> ertai
2012-07-11 14:21	doligez	Assigned To	ertai =>
2012-07-11 14:21	doligez	Status	assigned => acknowledged
2012-07-11 14:21	doligez	Target Version	=> 4.01.0+dev
2012-07-30 08:45	furuse	File Added: p4_expand_directory.diff
2012-07-30 08:45	furuse	Note Added: 0007831
2012-07-31 13:36	doligez	Target Version	4.01.0+dev => 4.00.1+dev
2012-09-17 17:24	doligez	Status	acknowledged => confirmed
2012-09-17 17:24	doligez	Target Version	4.00.1+dev => 4.00.2+dev