0004873: .mltop and "thread" tag

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0004873

OCaml

OCamlbuild (the tool)

public

2009-09-23 13:49

2011-05-29 12:20

Reporter

ygrek

Assigned To

xclerc

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

3.11.1

Target Version

Fixed in Version

3.11.2+dev

Summary

0004873: .mltop and "thread" tag

Description

'ocamlbuild target.top' ignores "thread" tag, and so one needs to manually specify missing options.
Consider:

$ cat q.ml
let test () = Thread.delay 1.0
$ cat _tags
true: thread, use_unix
$ cat q.mltop
Q
$ ocamlbuild q.byte
Finished, 3 targets (0 cached) in 00:00:00.
$ ocamlbuild q.top
+ /usr/bin/ocamlmktop unix.cma q.cmo -o q.top
File "_none_", line 1, characters 0-1:
Error: Error while linking q.cmo:
Reference to undefined global `Thread'
Command exited with code 2.
$ ocamlbuild -cflags -thread -lflags -thread -libs unix,threads q.top
Finished, 3 targets (2 cached) in 00:00:00.

Tags

No tags attached.

Attached Files

ocamlbuild.thread.diff [^] (733 bytes) 2009-11-05 11:57 [Show Content] [Hide Content]

Index: ocaml_specific.ml
===================================================================
--- ocaml_specific.ml	(revision 9408)
+++ ocaml_specific.ml	(working copy)
@@ -416,6 +416,8 @@
 flag ["ocaml"; "doc"; "thread"] (S[A"-I"; A"+threads"]);;
 flag ["ocaml"; "link"; "thread"; "native"; "program"] (S[A "threads.cmxa"; A "-thread"]);;
 flag ["ocaml"; "link"; "thread"; "byte"; "program"] (S[A "threads.cma"; A "-thread"]);;
+flag ["ocaml"; "link"; "thread"; "native"; "toplevel"] (S[A "threads.cmxa"; A "-thread"]);;
+flag ["ocaml"; "link"; "thread"; "byte"; "toplevel"] (S[A "threads.cma"; A "-thread"]);;
 flag ["ocaml"; "compile"; "nopervasives"] (A"-nopervasives");;
 flag ["ocaml"; "compile"; "nolabels"] (A"-nolabels");;

Relationships

Notes
(0005149) ygrek (reporter) 2009-11-05 11:58	trivial fix attached

Issue History
Date Modified	Username	Field	Change
2009-09-23 13:49	ygrek	New Issue
2009-11-05 11:57	ygrek	File Added: ocamlbuild.thread.diff
2009-11-05 11:58	ygrek	Note Added: 0005149
2009-12-07 09:41	xclerc	Status	new => resolved
2009-12-07 09:41	xclerc	Fixed in Version	=> 3.11.2+dev
2009-12-07 09:41	xclerc	Resolution	open => fixed
2009-12-07 09:41	xclerc	Assigned To	=> xclerc
2011-05-29 12:20	xleroy	Status	resolved => closed
2012-02-02 15:17	protz	Category	OCamlbuild => OCamlbuild (the tool)