Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.mltop and "thread" tag #4873

Closed
vicuna opened this issue Sep 23, 2009 · 1 comment
Closed

.mltop and "thread" tag #4873

vicuna opened this issue Sep 23, 2009 · 1 comment

Comments

@vicuna
Copy link

vicuna commented Sep 23, 2009

Original bug ID: 4873
Reporter: @ygrek
Assigned to: @xclerc
Status: closed (set by @xavierleroy on 2011-05-29T10:20:09Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 3.11.1
Fixed in version: 3.11.2+dev
Category: -for ocamlbuild use https://github.com/ocaml/ocamlbuild/issues

Bug description

'ocamlbuild target.top' ignores "thread" tag, and so one needs to manually specify missing options.
Consider:

$ cat q.ml
let test () = Thread.delay 1.0
$ cat _tags
true: thread, use_unix
$ cat q.mltop
Q
$ ocamlbuild q.byte
Finished, 3 targets (0 cached) in 00:00:00.
$ ocamlbuild q.top

  • /usr/bin/ocamlmktop unix.cma q.cmo -o q.top
    File "none", line 1, characters 0-1:
    Error: Error while linking q.cmo:
    Reference to undefined global `Thread'
    Command exited with code 2.
    $ ocamlbuild -cflags -thread -lflags -thread -libs unix,threads q.top
    Finished, 3 targets (2 cached) in 00:00:00.

File attachments

@vicuna
Copy link
Author

vicuna commented Nov 5, 2009

Comment author: @ygrek

trivial fix attached

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant