You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Original bug ID: 4900 Reporter:@mshinwell Status: closed (set by @damiendoligez on 2009-10-26T13:36:06Z) Resolution: open Priority: normal Severity: minor Version: 3.11.1 Fixed in version: 3.11.2+dev Category: ~DO NOT USE (was: OCaml general)
Bug description
I noticed this morning that gc_ctrl.c:test_and_compact, called from caml_gc_major and caml_gc_full_major, appears to be able to call caml_compact_heap (which doesn't test caml_percent_max) in the situation where the first calculation of fp yields >=1_000_000, caml_percent_max is set to 1_000_000, and there is more than one heap chunk.
Is the setting of caml_percent_max (aka max_overhead) to 1_000_000 not supposed to prevent automatic compaction in all cases? I wonder if the test in that function should be "fp > caml_percent_max", or whether 1_000_000 - 1 should be used for the saturating calculation.
The text was updated successfully, but these errors were encountered:
Original bug ID: 4900
Reporter: @mshinwell
Status: closed (set by @damiendoligez on 2009-10-26T13:36:06Z)
Resolution: open
Priority: normal
Severity: minor
Version: 3.11.1
Fixed in version: 3.11.2+dev
Category: ~DO NOT USE (was: OCaml general)
Bug description
I noticed this morning that gc_ctrl.c:test_and_compact, called from caml_gc_major and caml_gc_full_major, appears to be able to call caml_compact_heap (which doesn't test caml_percent_max) in the situation where the first calculation of fp yields >=1_000_000, caml_percent_max is set to 1_000_000, and there is more than one heap chunk.
Is the setting of caml_percent_max (aka max_overhead) to 1_000_000 not supposed to prevent automatic compaction in all cases? I wonder if the test in that function should be "fp > caml_percent_max", or whether 1_000_000 - 1 should be used for the saturating calculation.
The text was updated successfully, but these errors were encountered: