|Anonymous | Login | Signup for a new account||2016-08-25 08:19 CEST|
|Main | My View | View Issues | Change Log | Roadmap|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0004957||OCaml||OCaml general||public||2010-01-10 18:11||2016-04-19 14:25|
|Target Version||4.03.1+dev||Fixed in Version|
|Summary||0004957: ocamlc -where, camlp4 -where, etc. add \r\n on mingw|
|Description||I may be wrong, but I would find it easier to use if the eol of the string returned by ocamlc -where etc. was \n, not \r\n|
A lot of installers are broken or partially broken because of this.
|Tags||No tags attached.|
|Also keeping only forward slashes in these paths will make the life simpler. Currently there is the mix of forward and backslashes (msvc target).|
The problem is with mingw flavour of the distribution. Usually, it is used with "unix" tools (ocamlbuild, cygwin, …), while msvc flavour tend to use more "win" tools.
OCaml tools should be able to distinguish between msvc and mingw flavour, I would say, in order to adapt their ouptputs. I don't know if it is currently possible?
I'm aware of Sys.os_type. But it seems not enough detailed to me.
"Win32" is used both for mingw and MSVC.
Modifying Sys.os_type would break a lot of code. Maybe adding: Sys.os_flavour with more detailed information (mingw, msvc, unix, osx, …) would be a good first step?
|+1 for slashes in paths, even for msvc.|
I raise the severity to major as it breaks the installers. I think it would be sensible to expect from mingw port to return Unix style EOL delimiters.
However I think we don't expect it to fix it before 4.00.2, if you think it's a showstopper then please do let us know promptly, thanks.
|I'm not sure that the mingw and the msvc should behave differently. I understand that the current situation can break installers, but why is it specific to the mingw port? It makes perfect sense to use the msvc port even e.g. from Cygwin.|
I don't see what we could do here that would not be horribly ad-hoc. Owing to OCaml's bootstrapped nature, the mingw and msvc ports of OCaml both generate pure Win32 executables and are themselves pure Win32 executables. When they print something on standard output, it undergoes end-of-line conversion just like with all pure Win32 programs.
Concerning "breaking the installers": isn't ocamlfind the preferred way to install these days? and does it also suffer from this end-of-line issue?
One possible solution would be to not output any NL at the end of ocamlc -where. Since it is most likely to be used in a shell script between backquotes, there isn't really a need for the NL character(s).
For interactive use, the absence of NL would be at most a minor inconvenience.
|2010-01-10 18:11||matt||New Issue|
|2010-01-11 11:07||ygrek||Note Added: 0005226|
|2011-05-31 16:42||doligez||Status||new => acknowledged|
|2011-12-15 10:03||matt||Note Added: 0006305|
|2011-12-15 10:57||ripoche||Note Added: 0006307|
|2012-07-11 13:32||doligez||Target Version||=> 4.01.0+dev|
|2012-07-31 13:36||doligez||Target Version||4.01.0+dev => 4.00.1+dev|
|2012-09-10 05:09||meyer||Note Added: 0008041|
|2012-09-10 05:09||meyer||Severity||minor => major|
|2012-09-10 05:09||meyer||Target Version||4.00.1+dev => 4.00.2+dev|
|2013-01-15 14:31||frisch||Note Added: 0008756|
|2013-06-06 23:08||frisch||Severity||major => minor|
|2013-06-06 23:08||frisch||Target Version||4.00.2+dev => 4.02.0+dev|
|2013-07-12 18:15||doligez||Target Version||4.02.0+dev => 4.01.1+dev|
|2014-05-25 20:20||doligez||Target Version||4.01.1+dev => 4.02.0+dev|
|2014-07-31 15:59||doligez||Target Version||4.02.0+dev => 4.02.1+dev|
|2014-09-04 00:25||doligez||Target Version||4.02.1+dev => undecided|
|2014-09-26 17:46||doligez||Target Version||undecided => 4.02.2+dev / +rc1|
|2015-03-18 17:53||frisch||Target Version||4.02.2+dev / +rc1 => 4.03.0+dev / +beta1|
|2015-12-11 17:17||xleroy||Note Added: 0015133|
|2016-04-19 14:23||doligez||Note Added: 0015812|
|2016-04-19 14:25||doligez||Target Version||4.03.0+dev / +beta1 => 4.03.1+dev|
|Copyright © 2000 - 2011 MantisBT Group|