0005007: building ocamlbrowser under windows fails (can't find Mutex)

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0005007

OCaml

OCaml general

public

2010-03-22 15:29

2012-09-25 20:06

Reporter

Dmitry Grebeniuk

Assigned To

Priority

normal

Severity

trivial

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

3.12.0

Summary

0005007: building ocamlbrowser under windows fails (can't find Mutex)

Description

I'm trying to build svn' trunk under mingw:

../../../ocamlcomp.sh -o ocamlbrowser.exe -I ../../../otherlibs/win32unix -I ../../../otherlibs/str -I ../../../otherlibs/systhreads -I ../labltk -I ../lib -I ../support -I ../../../parsing -I ../../../utils -I ../../../typing \
../../../toplevel/toplevellib.cma \
unix.cma str.cma labltk.cma jglib.cma list2.cmo useunix.cmo setpath.cmo lexical.cmo fileselect.cmo searchid.cmo searchpos.cmo shell.cmo help.cmo viewer.cmo typecheck.cmo editor.cmo main.cmo
File "_none_", line 1, characters 0-1:
Error: Error while linking shell.cmo:
Reference to undefined global `Mutex'
make[4]: *** [ocamlbrowser.exe] Error 2
make[4]: Leaving directory `/d/gds/dev/overbld/20100318/work312/src/ocaml/work/otherlibs/labltk/browser'
make[3]: *** [all] Error 2
make[3]: Leaving directory `/d/gds/dev/overbld/20100318/work312/src/ocaml/work/otherlibs/labltk'
make[2]: *** [otherlibraries] Error 2
make[2]: Leaving directory `/d/gds/dev/overbld/20100318/work312/src/ocaml/work'

The fix is trivial, see uploaded patch.

Tags

No tags attached.

Attached Files

ocamlbrowser_mutex.patch [^] (1,239 bytes) 2010-03-22 15:29 [Show Content] [Hide Content]

diff -r -U5 orig/otherlibs/labltk/browser/Makefile.nt copyfiles/otherlibs/labltk/browser/Makefile.nt
--- orig/otherlibs/labltk/browser/Makefile.nt	2008-12-03 18:09:09 +0000
+++ copyfiles/otherlibs/labltk/browser/Makefile.nt	2010-03-22 13:02:33 +0000
@@ -11,11 +11,11 @@
 else
 WINDOWS_APP=-ccopt "-link /subsystem:windows"
 endif
 
 XTRAOBJ=winmain.$(O)
-XTRALIBS=threads.cma -custom $(WINDOWS_APP)
+XTRALIBS=unix.cma threads.cma -custom $(WINDOWS_APP)
 
 include Makefile.shared
 
 dummy.mli:
 	cp dummyWin.mli dummy.mli
diff -r -U5 orig/otherlibs/labltk/browser/Makefile.shared copyfiles/otherlibs/labltk/browser/Makefile.shared
--- orig/otherlibs/labltk/browser/Makefile.shared	2010-01-22 12:48:24 +0000
+++ copyfiles/otherlibs/labltk/browser/Makefile.shared	2010-03-22 12:54:39 +0000
@@ -29,11 +29,11 @@
 
 all: ocamlbrowser$(EXE)
 
 ocamlbrowser$(EXE): $(TOPDIR)/toplevel/toplevellib.cma jglib.cma $(OBJ) \
 			../support/lib$(LIBNAME).$(A)
-	$(CAMLC) -o ocamlbrowser$(EXE) $(INCLUDES) \
+	$(CAMLC) -o ocamlbrowser$(EXE) $(XTRALIBS) $(INCLUDES) \
 		$(TOPDIR)/toplevel/toplevellib.cma \
 		unix.cma str.cma $(OCAMLBR) $(LIBNAME).cma jglib.cma $(OBJ)
 
 ocamlbrowser.cma: jglib.cma $(OBJ)
 	$(CAMLC) -a -o $@ -linkall jglib.cma $(OBJ)

Relationships

Notes
(0005952) doligez (manager) 2011-06-01 17:15	This is already fixed in 3.12.0, right?

Issue History
Date Modified	Username	Field	Change
2010-03-22 15:29	Dmitry Grebeniuk	New Issue
2010-03-22 15:29	Dmitry Grebeniuk	File Added: ocamlbrowser_mutex.patch
2011-06-01 17:15	doligez	Note Added: 0005952
2011-06-01 17:15	doligez	Status	new => resolved
2011-06-01 17:15	doligez	Resolution	open => fixed
2011-06-01 17:15	doligez	Fixed in Version	=> 3.12.0
2012-09-25 20:06	xleroy	Status	resolved => closed