0005099: Dependencies at byte-code link with mlpack

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0005099

OCaml

OCamlbuild (the tool)

public

2010-07-08 23:19

2010-07-22 11:39

Reporter

gsutre

Assigned To

xclerc

Priority

normal

Severity

feature

Reproducibility

always

Status

assigned

Resolution

open

Platform

OS Version

Product Version

3.12.0+beta1 or 3.12.0+rc1

Target Version

Fixed in Version

Summary

0005099: Dependencies at byte-code link with mlpack

Description

I obtain an error `Reference to undefined global ...' with ocamlbuild in
the following situation.

[File] [Contents]

example
|-- Main.ml let _ = Pack.Packed.g ()
|
|-- Pack.mlpack pack/Packed
|
|-- _tags <lib>: include
| <pack/*.cmx>: for-pack(Pack)
|
|-- lib
| |-- Lib.ml let f () = ()
| `-- Lib.mli val f : unit -> unit
`-- pack
`-- Packed.ml let g () = Lib.f ()

$ ocamlbuild -classic-display Main.byte
/usr/pkg/bin/ocamldep.opt -modules Main.ml > Main.ml.depends
/usr/pkg/bin/ocamldep.opt -modules pack/Packed.ml > pack/Packed.ml.depends
/usr/pkg/bin/ocamldep.opt -modules lib/Lib.mli > lib/Lib.mli.depends
/usr/pkg/bin/ocamlc.opt -c -I lib -o lib/Lib.cmi lib/Lib.mli
/usr/pkg/bin/ocamlc.opt -c -I pack -I lib -o pack/Packed.cmo pack/Packed.ml
/usr/pkg/bin/ocamlc.opt -pack pack/Packed.cmo -o Pack.cmo
/usr/pkg/bin/ocamlc.opt -c -I lib -o Main.cmo Main.ml
/usr/pkg/bin/ocamlc.opt Pack.cmo Main.cmo -o Main.byte
+ /usr/pkg/bin/ocamlc.opt Pack.cmo Main.cmo -o Main.byte
File "_none_", line 1, characters 0-1:
Error: Error while linking Pack.cmo:
Reference to undefined global `Lib'
Command exited with code 2.

If I read the code correctly, this comes from the function prepare_link
in ocaml_compiler.ml which derives the dependencies from the files
.ml.depends and .mli.depends. But these files are not generated for
packs, hence the required dependencies are not build.

The attached small patch (patch-ocamlbuild-link-pack-deps.diff) simply
treats the .mlpack files as dependency files for packs, which fixes
the issue.

Additional Information

This byte-code linking problem with packs was reported to the list
two years ago, but with no answer:

http://caml.inria.fr/pub/ml-archives/caml-list/2008/06/784c154d0f7b53995c0167ac63fc5bb9.en.html [^]

I also recently sent a message (with attachments) to the Caml mailing list
regarding this issue:

http://groups.google.com/group/fa.caml/browse_thread/thread/73943caba65dbc3c [^]

Tags

No tags attached.

Attached Files

patch-ocamlbuild-link-pack-deps.diff [^] (805 bytes) 2010-07-08 23:19 [Show Content] [Hide Content]

Index: ocamlbuild/ocaml_compiler.ml
===================================================================
--- ocamlbuild/ocaml_compiler.ml	(revision 10605)
+++ ocamlbuild/ocaml_compiler.ml	(working copy)
@@ -144,6 +144,12 @@
       (if Pathname.exists (ml-.-"depends") then path_dependencies_of ml else [])
       (if Pathname.exists (mli-.-"depends") then path_dependencies_of mli else [])
   in
+  let modules =
+    if (modules = []) && (Pathname.exists (ml^"pack")) then
+      List.map (fun s -> (`mandatory, s)) (string_list_of_file (ml^"pack"))
+    else
+      modules
+  in
   if modules <> [] && not (Hashtbl.mem cache_prepare_link key) then
     let () = Hashtbl.add cache_prepare_link key true in
     let modules' = List.map (fun (_, x) -> expand_module include_dirs x extensions) modules in

example.diff [^] (1,252 bytes) 2010-07-08 23:21 [Show Content] [Hide Content]

diff -Naur example/lib/Lib.ml example/lib/Lib.ml
--- example/lib/Lib.ml	1970-01-01 01:00:00.000000000 +0100
+++ example/lib/Lib.ml	2010-06-26 18:59:36.000000000 +0200
@@ -0,0 +1 @@
+let f () = ()
diff -Naur example/lib/Lib.mli example/lib/Lib.mli
--- example/lib/Lib.mli	1970-01-01 01:00:00.000000000 +0100
+++ example/lib/Lib.mli	2010-06-26 23:18:01.000000000 +0200
@@ -0,0 +1 @@
+val f : unit -> unit
diff -Naur example/Main.ml example/Main.ml
--- example/Main.ml	1970-01-01 01:00:00.000000000 +0100
+++ example/Main.ml	2010-06-26 23:26:54.000000000 +0200
@@ -0,0 +1 @@
+let _ = Pack.Packed.g ()
diff -Naur example/pack/Packed.ml example/pack/Packed.ml
--- example/pack/Packed.ml	1970-01-01 01:00:00.000000000 +0100
+++ example/pack/Packed.ml	2010-06-26 23:23:27.000000000 +0200
@@ -0,0 +1 @@
+let g () = Lib.f ()
diff -Naur example/Pack.mlpack example/Pack.mlpack
--- example/Pack.mlpack	1970-01-01 01:00:00.000000000 +0100
+++ example/Pack.mlpack	2010-06-26 23:24:30.000000000 +0200
@@ -0,0 +1 @@
+pack/Packed
diff -Naur example/_tags example/_tags
--- example/_tags	1970-01-01 01:00:00.000000000 +0100
+++ example/_tags	2010-06-26 23:24:57.000000000 +0200
@@ -0,0 +1,4 @@
+# include local sources
+<lib>: include
+
+<pack/*.cmx>: for-pack(Pack)

Relationships

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2010-07-08 23:19	gsutre	New Issue
2010-07-08 23:19	gsutre	File Added: patch-ocamlbuild-link-pack-deps.diff
2010-07-08 23:21	gsutre	File Added: example.diff
2010-07-22 11:39	ertai	Status	new => assigned
2010-07-22 11:39	ertai	Assigned To	=> xclerc
2012-02-02 15:17	protz	Category	OCamlbuild => OCamlbuild (the tool)