New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extra TySum constructors arise from <:ctyp< >> in original syntax #5104
Comments
Comment author: @xclerc For the record, here are the comparisons between (1) 3.11.0, and (2) the sources <:ctyp< Foo >> gives: <:ctyp< Foo of unit >> gives: <:ctyp< Foo | Bar >> gives: <:ctyp< <:ctyp< |
Comment author: @xclerc Here is a tentative patch. Index: camlp4/Camlp4Parsers/Camlp4OCamlParser.ml--- camlp4/Camlp4Parsers/Camlp4OCamlParser.ml (revision 10948)
@@ -534,6 +531,9 @@
|
Comment author: Dmitry Grebeniuk I've compiled last ocaml version from svn trunk with this patch. $ cat aaa.ml $ ocamlc aaa.ml $ cat bbb.ml $ ocamlc bbb.ml |
Comment author: @xclerc Thanks for the feedback, seems like I mixed up results from |
Comment author: @xclerc Provided that my work was a bit more coherent, here is a patch that However, the eyes of a camlp4-guru would be useful to bless this patch. Index: camlp4/Camlp4Parsers/Camlp4OCamlParser.ml--- camlp4/Camlp4Parsers/Camlp4OCamlParser.ml (revision 10948)
|
Comment author: @xclerc Nicolas Pouillard provided me with a cleaner patch that has Please test it, and re-open the issue if I missed something. |
Original bug ID: 5104
Reporter: jaked
Assigned to: @xclerc
Status: closed (set by @xavierleroy on 2015-12-11T18:04:45Z)
Resolution: fixed
Priority: normal
Severity: major
Version: 3.12.0+beta1 or 3.12.0+rc1
Fixed in version: 4.00.0+dev
Category: -for Camlp4 use https://github.com/ocaml/camlp4/issues
Related to: #5080 #5231
Monitored by: @hcarty
Bug description
Extra TySum constructors arise from <:ctyp< >> quotations compared to 3.11.x. E.g.
<:ctyp< Foo >>, <:ctyp< Foo of unit >>, <:ctyp< Foo | Bar >>, <:ctyp<$x$ and $y$ >>
and, more strangely, since this does not involve sums
<:ctyp<$x$ ; $y$ >>
In order to be portable between 3.11.x and 3.12.x I need to use Ast constructors directly.
The text was updated successfully, but these errors were encountered: