Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve location for identifiers in the camlp4 ast #5147

Closed
vicuna opened this issue Sep 16, 2010 · 2 comments
Closed

improve location for identifiers in the camlp4 ast #5147

vicuna opened this issue Sep 16, 2010 · 2 comments

Comments

@vicuna
Copy link

vicuna commented Sep 16, 2010

Original bug ID: 5147
Reporter: Hendrik Tews
Assigned to: @xclerc
Status: closed (set by @diml on 2016-12-07T17:27:41Z)
Resolution: open
Priority: normal
Severity: feature
Version: 3.12.0
Category: -for Camlp4 use https://github.com/ocaml/camlp4/issues

Bug description

This is a feature wish for otags: In the following cases I have
to parse parts of the input a second time (after camlp4) because
there is not sufficient location information available.

Here are the problematic cases:

  1. "type t = ..." : There is no location info for "t" in the
    camlp4 ast. This location is non-trivial to compute, because
    there might be type parameters between "type" and "t".

  2. "class type x = object val s : int end" : There is no location
    info for "s"

  3. same for the "s" in "class type x = object method virtual s : int end"

  4. same for the "s" in "class type x = object method s : int end"

  5. same for the "s" in ``external s : int->int = "xx" '' in
    interfaces and structures

  6. same for the "S" in "module S : ..." in interfaces.

  7. same for the "S" in "module type S = ..." in interfaces.

  8. same for the "s" in "val s : int" in interfaces.

  9. same for the "s" in "class t = object val s = 0 end" in
    structures.

  10. same for the "s" in "class t = object val virtual s : int
    end" in structures.

  11. same for the "s" in "class t = object method virtual s : int
    end" in structures.

  12. same for the "s" in "class t = object method s = 0 end" in structure.

  13. same for the "S" in "module S = ..." in structures.

  14. same for the "S" in "module type S = ..." in structures.

@vicuna
Copy link
Author

vicuna commented May 16, 2012

Comment author: Hendrik Tews

  1. same for "S" in "module rec S : ..." in signatures and structures

@vicuna
Copy link
Author

vicuna commented Dec 7, 2016

Comment author: @diml

Camlp4 is now a separate project. Please re-open a ticket on github [1] if you are still interested in seeing the original issue fixed.

[1] https://github.com/ocaml/camlp4/issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant