0005177: Gc.compact does implies Gc.full_major

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0005177

OCaml

OCaml general

public

2010-11-10 16:09

2010-11-10 16:47

Reporter

frisch

Assigned To

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

3.12.1+dev

Summary

0005177: Gc.compact does implies Gc.full_major

Description

The doc for Gc.compact says: "Perform a full major collection and compact the heap."

However, reading the implementation in byterun/gc_ctrl.c, one can see that compact does not do the same set of operations as full_major:

full_major:
  caml_empty_minor_heap ();
  caml_finish_major_cycle ();
  caml_final_do_calls ();
  caml_empty_minor_heap ();
  caml_finish_major_cycle ();

compact:
  caml_empty_minor_heap ();
  caml_finish_major_cycle ();
  caml_finish_major_cycle ();

I believe it would be a good idea to do the extra final_do_calls/empty_minor_heap in compact as well.

Tags

No tags attached.

Attached Files

Relationships

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2010-11-10 16:09	frisch	New Issue
2010-11-10 16:47	doligez	Status	new => closed
2010-11-10 16:47	doligez	Resolution	open => fixed
2010-11-10 16:47	doligez	Fixed in Version	=> 3.12.1+dev