Original bug ID: 5188
Reporter: herbelin
Assigned to: @xavierleroy
Status: closed (set by @xavierleroy on 2012-03-24T14:01:40Z)
Resolution: fixed
Priority: normal
Severity: crash
Version: 3.11.2
Fixed in version: 3.12.1+dev
Category: ~DO NOT USE (was: OCaml general)
Related to: #7220
Monitored by: @glondu

Bug description

Hi, the following code randomly but most often leads to a double free corruption.

let rec f x = if x = 0 then 0 else 1 + f (x-1)
let _ = Thread.join (Thread.create f 200)

(compiled with "ocamlc -thread unix.cma threads.cma bug.ml").

A valgrind analysis showed that the second illegal free is raised by the instruction "stat_free(th->stack_low);" at line 449 of posix.c: a reallocation of the stack happened but the th and th->stack_low did not get a chance to be updated yet (no entering in a blocking section). The attached patch seems to solve the problem in 3.11.

Apparently, thread implementation has been revised in 3.12 but the problem remains.

Incidentally, with a large system such as Coq, if we link it with the thread library, even though we might not make any use of the functions of the library, we randomly experiment out of memory errors at startup (in native code). Any ideas how to debug this?

Best regards. Hugo.

File attachments

• patch.double-free-3.11