0005192: wosize vs. real size in comballoc.ml

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Tags

No tags attached.

Attached Files

comballoc.patch [^] (671 bytes) 2010-12-10 00:18 [Show Content] [Hide Content]

diff --git a/asmcomp/comballoc.ml b/asmcomp/comballoc.ml
index 5a862b1..13dbcaf 100644
--- a/asmcomp/comballoc.ml
+++ b/asmcomp/comballoc.ml
@@ -38,7 +38,7 @@ let rec combine i allocstate =
             combine i.next (Pending_alloc(i.res.(0), sz)) in
           (instr_cons (Iop(Ialloc newsz)) i.arg i.res newnext, 0)
       | Pending_alloc(reg, ofs) ->
-          if ofs + sz < Config.max_young_wosize then begin
+          if ofs + sz < Config.max_young_wosize * Arch.size_addr then begin
             let (newnext, newsz) =
               combine i.next (Pending_alloc(reg, ofs + sz)) in
             (instr_cons (Iop(Iintop_imm(Iadd, ofs))) [| reg |] i.res newnext,

Relationships

Notes
(0005751) xleroy (administrator) 2010-12-22 14:53	Well spotted, thanks. You are correct that sizes are counted in bytes in Comballoc and throughout the OCaml back-end. Patch applied in bugfix branch 3.12, will go in release 3.12.1.

Issue History
Date Modified	Username	Field	Change
2010-12-10 00:18	meurer	New Issue
2010-12-10 00:18	meurer	File Added: comballoc.patch
2010-12-22 14:53	xleroy	Note Added: 0005751
2010-12-22 14:53	xleroy	Assigned To	=> xleroy
2010-12-22 14:53	xleroy	Status	new => resolved
2010-12-22 14:53	xleroy	Resolution	open => fixed
2010-12-22 14:53	xleroy	Fixed in Version	=> 3.12.1+dev
2012-03-24 15:01	xleroy	Status	resolved => closed