Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply const int optimizations to const natint #5195

Closed
vicuna opened this issue Dec 14, 2010 · 3 comments
Closed

Apply const int optimizations to const natint #5195

vicuna opened this issue Dec 14, 2010 · 3 comments

Comments

@vicuna
Copy link

vicuna commented Dec 14, 2010

Original bug ID: 5195
Reporter: meurer
Status: feedback (set by @mshinwell on 2016-12-07T13:45:23Z)
Resolution: open
Priority: normal
Severity: feature
Version: 3.12.1+dev
Category: back end (clambda to assembly)
Tags: patch
Monitored by: @gasche @Chris00

Bug description

This patch alters selectgen.ml and amd64/selection.ml to apply the same optimizations to operations with Cconst_natint that are already applied to operations with Cconst_int. It's really straight-forward. Adds a new virtual method is_immediate_natint to the selector class, which will have to be added to the other backends as well.

File attachments

@vicuna
Copy link
Author

vicuna commented Dec 7, 2016

Comment author: @mshinwell

@meurer: If this is still important to you, please make a Github pull request with this patch, and close this issue. Thanks.

@github-actions
Copy link

This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc.

@github-actions github-actions bot added the Stale label May 15, 2020
@mshinwell
Copy link
Contributor

There was no feedback following a ping at the end of 2016, so closing. @bmeurer Please submit a PR if this is still important, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants