0005209: natdynlink not built because configure contains an incorrect test for FreeBSD

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0005209

OCaml

OCaml general

public

2011-01-25 19:04

2012-09-25 20:06

Reporter

dra

Assigned To

xclerc

Priority

normal

Severity

block

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

3.12.0

Target Version

Fixed in Version

3.12.1+dev

Summary

0005209: natdynlink not built because configure contains an incorrect test for FreeBSD

Description

The test for FreeBSD for natdynlink support in OCaml's configure script seems to be incorrect. I don't know why the cases contain a 'k' or why i386 (the default name for x86) is not included. Is kfreebsd ever a correct symbol? Removing it and allowing 386 allows successful use of natdynlink on FreeBSD 8.1 (a simple test works as well).

This bug would seem to have been introduced with 3.12.0 (the version of configure in 3.11.2 doesn't do this which is presumably why the BSD port maintainer hasn't reported a bug...)

Additional Information

The line numbers aren't correct (I'd changed some other things in configure) but the context should be enough:

@@ -626,8 +639,9 @@
     i[3456]86-*-darwin[89]*) natdynlink=true;;
     powerpc64-*-linux*) natdynlink=true;;
     sparc-*-linux*) natdynlink=true;;
- i686-*-kfreebsd*) natdynlink=true;;
- x86_64-*-kfreebsd*) natdynlink=true;;
+
+ i[36]86-*-freebsd*) natdynlink=true;;
+ x86_64-*-freebsd*) natdynlink=true;;
     i386-*-gnu0.3) natdynlink=true;;
   esac
fi

Tags

No tags attached.

Attached Files

Relationships

related to

0005273

acknowledged

natdynlink disabled following faulty test in configure script

Notes
(0005825) xclerc (developer) 2011-02-21 15:01	fix tested on a 'real' NetBSD instance, and on a 'virtualized' FreeBSD instance

Issue History
Date Modified	Username	Field	Change
2011-01-25 19:04	dra	New Issue
2011-02-21 14:58	xclerc	Status	new => assigned
2011-02-21 14:58	xclerc	Assigned To	=> xclerc
2011-02-21 15:01	xclerc	Note Added: 0005825
2011-02-21 15:01	xclerc	Status	assigned => resolved
2011-02-21 15:01	xclerc	Fixed in Version	=> 3.12.1+dev
2011-02-21 15:01	xclerc	Resolution	open => fixed
2011-06-01 23:39	doligez	Relationship added	related to 0005273
2012-09-25 20:06	xleroy	Status	resolved => closed