0005237: ocamlopt for amd64 fails with binutils 2.21

From: Stephane Glondu <steph@glondu.net> Date: Tue, 8 Mar 2011 21:17:40 +0100 Subject: [PATCH] Fix ocamlopt w.r.t. binutils 2.21 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: http://caml.inria.fr/mantis/view.php?id=5237 Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=617404 Authors: Eric Cooper, spiralvoice Reviewed-by: Stéphane Glondu <steph@glondu.net> --- asmcomp/amd64/emit.mlp | 13 +++++++------ asmcomp/i386/emit.mlp | 6 +++--- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/asmcomp/amd64/emit.mlp b/asmcomp/amd64/emit.mlp index 4a3f844..525c6e6 100644 --- a/asmcomp/amd64/emit.mlp +++ b/asmcomp/amd64/emit.mlp @@ -679,17 +679,18 @@ let fundecl fundecl = emit_all true fundecl.fun_body; List.iter emit_call_gc !call_gc_sites; emit_call_bound_errors (); + begin match Config.system with + "linux" | "gnu" -> + ` .type {emit_symbol fundecl.fun_name},@function\n`; + ` .size {emit_symbol fundecl.fun_name},.-{emit_symbol fundecl.fun_name}\n` + | _ -> () + end; if !float_constants <> [] then begin if macosx then ` .literal8\n` else ` .section .rodata.cst8,\"a\",@progbits\n`; List.iter emit_float_constant !float_constants - end; - match Config.system with - "linux" | "gnu" -> - ` .type {emit_symbol fundecl.fun_name},@function\n`; - ` .size {emit_symbol fundecl.fun_name},.-{emit_symbol fundecl.fun_name}\n` - | _ -> () + end (* Emission of data *) diff --git a/asmcomp/i386/emit.mlp b/asmcomp/i386/emit.mlp index 2992f29..0b1252c 100644 --- a/asmcomp/i386/emit.mlp +++ b/asmcomp/i386/emit.mlp @@ -905,12 +905,12 @@ let fundecl fundecl = emit_all true fundecl.fun_body; List.iter emit_call_gc !call_gc_sites; emit_call_bound_errors (); - List.iter emit_float_constant !float_constants; - match Config.system with + begin match Config.system with "linux_elf" | "bsd_elf" | "gnu" -> ` .type {emit_symbol fundecl.fun_name},@function\n`; ` .size {emit_symbol fundecl.fun_name},.-{emit_symbol fundecl.fun_name}\n` - | _ -> () + | _ -> () end; + List.iter emit_float_constant !float_constants (* Emission of data *) --

Notes
(0005841) ecc (reporter) 2011-03-08 04:59	The attached patch seems to fix the issue by reordering the .section directive. Almost the entire test suite passes. (The one failure was stack overflow detection in native code -- the overflow is detected, but the stack size is evidently different than was used for the reference output.)

(0005842) spiralvoice (reporter) 2011-03-08 20:59	A similar problems happens when compiling Ocaml 3.12.0 on Debian sid x86 ../boot/ocamlrun ../ocamlopt -warn-error A -nostdlib -g `./Compflags random.cmx` -c random.ml /tmp/camlasm09faba.s: Assembler messages: /tmp/camlasm09faba.s:2064: Error: .size expression does not evaluate to a constant File "random.ml", line 1, characters 0-1: Error: Assembler error, input left in file /tmp/camlasm09faba.s

(0005843) spiralvoice (reporter) 2011-03-08 21:00	The attached patch fixed the problem here

(0005844) glondu (reporter) 2011-03-08 21:34	There are also sparc and powerpc as native architectures on Debian... but they don't seem to be affected by this bug (I've checked on sparc, powerpc looks similar). I've opened a Debian bug to keep track of this issue: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=617404 [^]

(0005845) int-e (reporter) 2011-03-09 15:55	Note that you need a very recent binutils release to reproduce this error: 2.21.0.20110216 (Debian sid) did not have this check.

(0005846) glondu (reporter) 2011-03-09 20:03	Note that spiralvoice's patch is incorrect. Attached is the patch (merging Eric and spiralvoice's ones) as applied in Debian.

(0005847) xleroy (administrator) 2011-03-13 14:37	S. Glondu's patch is correct. Applied in 3.12 bugfix branch and in trunk. Will be part of release 3.12.1.

Issue History
Date Modified	Username	Field	Change
2011-03-07 23:25	ecc	New Issue
2011-03-08 04:52	ecc	File Added: 0001-fix-assembly-failure-with-binutils-2.21.patch
2011-03-08 04:59	ecc	Note Added: 0005841
2011-03-08 20:59	spiralvoice	Note Added: 0005842
2011-03-08 21:00	spiralvoice	File Added: fix_ocaml3120.diff
2011-03-08 21:00	spiralvoice	Note Added: 0005843
2011-03-08 21:34	glondu	Note Added: 0005844
2011-03-09 15:55	int-e	Note Added: 0005845
2011-03-09 20:04	glondu	Note Added: 0005846
2011-03-09 20:05	glondu	File Added: 0007-Fix-ocamlopt-w.r.t.-binutils-2.21.patch
2011-03-13 14:37	xleroy	Note Added: 0005847
2011-03-13 14:37	xleroy	Assigned To	=> xleroy
2011-03-13 14:37	xleroy	Status	new => resolved
2011-03-13 14:37	xleroy	Resolution	open => fixed
2011-03-13 14:37	xleroy	Fixed in Version	=> 3.12.1+dev
2012-09-25 20:06	xleroy	Status	resolved => closed

Relationships