Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong ext_ref entries in .annot files when the path contains sub-modules #5269

Closed
vicuna opened this issue May 18, 2011 · 2 comments
Closed
Labels

Comments

@vicuna
Copy link

vicuna commented May 18, 2011

Original bug ID: 5269
Reporter: @alainfrisch
Assigned to: @xclerc
Status: closed (set by @xavierleroy on 2012-09-25T18:06:17Z)
Resolution: fixed
Priority: normal
Severity: minor
Fixed in version: 3.12.1
Category: ~DO NOT USE (was: OCaml general)

Bug description

An external reference to an identifier X.A.x is printed like that in the .annot file:

ident(
ext_ref X.( A ).x
)

This is because of the function Oprint.parenthesized_ident, called in typecore.ml (function type_exp, case Pexp_ident).

@vicuna
Copy link
Author

vicuna commented May 18, 2011

Comment author: @alainfrisch

The only other use of parenthesized_ident is in the function Oprint.value_ident, which is only used in print_out_sig_item for value items. So changing parenthesized_ident by adding the range 'A'..'Z' should not have any other effect than fixing .annot files.

@vicuna
Copy link
Author

vicuna commented May 18, 2011

Comment author: @xclerc

This is what I did in a tentative fix (revision 11051) in branch "version/3.12".
I should have read your note before working on the fix...

@vicuna vicuna closed this as completed Sep 25, 2012
@vicuna vicuna added the bug label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant