| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] |
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0005308 | OCaml | OCaml general | public | 2011-07-03 23:48 | 2011-07-04 20:31 |
|
| Reporter | lefessan | |
| Assigned To | doligez | |
| Priority | high | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | all | OS | all | OS Version | all |
| Product Version | 3.12.0 | |
| Target Version | | Fixed in Version | 3.12.1+dev | |
|
| Summary | 0005308: unused variables not detected in "include (struct .. end)", with fix |
| Description | Unused variables are not detected for expressions defined inside "include (struct ... end)". Such expressions can often appear as the result of preprocessing.
The provided patch trivially fix the problem for 3.12.0.
|
| Tags | No tags attached. |
|
| Attached Files | patch-include-unused_vars-3.12.0.diff [^] (532 bytes) 2011-07-03 23:48 [Show Content] [Hide Content]*** ocaml-3.12.0-orig/typing/unused_var.ml 2010-04-08 05:58:41.000000000 +0200
--- ocaml-3.12.0/typing/unused_var.ml 2011-07-03 10:26:16.885683000 +0200
***************
*** 106,110 ****
| Pstr_class cdl -> List.iter (class_declaration ppf tbl) cdl;
| Pstr_class_type _ -> ()
! | Pstr_include _ -> ()
and expression ppf tbl e =
--- 106,110 ----
| Pstr_class cdl -> List.iter (class_declaration ppf tbl) cdl;
| Pstr_class_type _ -> ()
! | Pstr_include me -> module_expr ppf tbl me
and expression ppf tbl e =
|
|