0005313: ocamlopt -g misses optimizations

(0006278)
meyer (developer)
2011-12-13 21:25
edited on: 2011-12-13 21:27

This is not longer happening on trunk with r11307:

$ ../../bin/ocamlopt -g -dlambda -c opt.ml:
(seq
  (let (x/1030 0)
    (before 17-54
      (for i/1031 1 to 10 (before 38-49 (assign x/1030 (+ x/1030 i/1031))))))
  0a)

(0006279)
meyer (developer)
2011-12-13 21:51

I suspect it was fixed on trunk with PR#5205 @ r11085..

Could you confirm it's been fixed with the current trunk?

(0006289)
ygrek (reporter)
2011-12-14 13:49

Yes, this exact use case is fixed, thanks!

But I am not sure that using -g will not prevent other optimizations cause looking at the code it seems that some optimization passes take -g option into the consideration. Actually, initially I wanted to clarify the meaning of -g and this specific example was the easiest to spot. So is it expected for -g to influence the generated code?

(0006296)
gasche (developer)
2011-12-15 00:53

I created the more accurate bug 0005426 to track the new question. Thanks for your participation.

(0006511)
meyer (developer)
2011-12-22 20:08

Reopening, as one place in the code needs better handling of -g flag

Issue History
Date Modified	Username	Field	Change
2011-07-10 12:34	ygrek	New Issue
2011-12-13 21:25	meyer	Note Added: 0006278
2011-12-13 21:27	meyer	Note Edited: 0006278	View Revisions
2011-12-13 21:51	meyer	Note Added: 0006279
2011-12-14 08:37	gasche	Status	new => feedback
2011-12-14 13:49	ygrek	Note Added: 0006289
2011-12-14 13:49	ygrek	Status	feedback => new
2011-12-15 00:51	gasche	Relationship added	related to 0005426
2011-12-15 00:53	gasche	Note Added: 0006296
2011-12-15 00:53	gasche	Status	new => closed
2011-12-15 00:53	gasche	Resolution	open => fixed
2011-12-22 20:08	meyer	Assigned To	=> meyer
2011-12-22 20:08	meyer	Note Added: 0006511
2011-12-22 20:08	meyer	Status	closed => feedback
2011-12-22 20:08	meyer	Resolution	fixed => reopened
2011-12-22 20:15	meyer	Status	feedback => resolved
2011-12-22 20:15	meyer	Fixed in Version	=> 3.13.0+dev
2011-12-22 20:15	meyer	Resolution	reopened => fixed
2012-09-25 20:07	xleroy	Status	resolved => closed

Notes
(0006278) meyer (developer) 2011-12-13 21:25 edited on: 2011-12-13 21:27	This is not longer happening on trunk with r11307: $ ../../bin/ocamlopt -g -dlambda -c opt.ml: (seq (let (x/1030 0) (before 17-54 (for i/1031 1 to 10 (before 38-49 (assign x/1030 (+ x/1030 i/1031)))))) 0a)

(0006279) meyer (developer) 2011-12-13 21:51	I suspect it was fixed on trunk with PR#5205 @ r11085.. Could you confirm it's been fixed with the current trunk?

(0006289) ygrek (reporter) 2011-12-14 13:49	Yes, this exact use case is fixed, thanks! But I am not sure that using -g will not prevent other optimizations cause looking at the code it seems that some optimization passes take -g option into the consideration. Actually, initially I wanted to clarify the meaning of -g and this specific example was the easiest to spot. So is it expected for -g to influence the generated code?

(0006296) gasche (developer) 2011-12-15 00:53	I created the more accurate bug 0005426 to track the new question. Thanks for your participation.

(0006511) meyer (developer) 2011-12-22 20:08	Reopening, as one place in the code needs better handling of -g flag