| Anonymous | Login | Signup for a new account | 2013-06-19 12:09 CEST | ![]() |
| Main | My View | View Issues | Change Log | Roadmap |
| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||||
| 0005350 | OCaml | OCaml general | public | 2011-08-27 19:40 | 2013-06-06 23:06 | ||||||
| Reporter | elfring | ||||||||||
| Assigned To | lefessan | ||||||||||
| Priority | normal | Severity | major | Reproducibility | have not tried | ||||||
| Status | acknowledged | Resolution | open | ||||||||
| Platform | OS | OS Version | |||||||||
| Product Version | 3.12.1 | ||||||||||
| Target Version | 4.01.0+dev | Fixed in Version | |||||||||
| Summary | 0005350: Check return codes everywhere | ||||||||||
| Description | Some checks for return codes are missing. Examples: Would you like to add more error handling for return values from "lseek" like in the function "read_trailer" and from "fprintf" in the function "caml_trace_value_file"? | ||||||||||
| Additional Information | http://caml.inria.fr/cgi-bin/viewcvs.cgi/ocaml/trunk/byterun/startup.c?rev=11156&view=auto [^] http://caml.inria.fr/cgi-bin/viewcvs.cgi/ocaml/trunk/byterun/instrtrace.c?rev=11156&view=auto [^] | ||||||||||
| Tags | No tags attached. | ||||||||||
| Attached Files | |||||||||||
Notes |
|
|
(0006106) elfring (reporter) 2011-08-27 21:50 |
I suggest to avoid unchecked function calls. Would you like to detect every error situation as early as possible? Another update candidate: function "editbuffer_getasline" ? realloc() http://caml.inria.fr/cgi-bin/viewcvs.cgi/ocaml/trunk/win32caml/editbuffer.c?rev=11156&view=auto [^] |
|
(0007169) lefessan (developer) 2012-03-26 16:05 |
"lseek" would indeed need a fix, but the other functions are mostly debug functions, where error handling is not important. |
|
(0007172) elfring (reporter) 2012-03-26 16:21 |
How do you think about a topic like "How to raise warning if return value is disregarded - gcc or static code check?"? http://stackoverflow.com/questions/2042780/how-to-raise-warning-if-return-value-is-disregarded-gcc-or-static-code-check [^] How do you think about to apply aspect-oriented software development? http://coccinelle.lip6.fr/ [^] http://research.msrg.utoronto.ca/ACC/Tutorial#A_Reusable_Aspect_for_Memory_All [^] http://aspectc.org/ [^] |
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2011-08-27 19:40 | elfring | New Issue | |
| 2011-08-27 21:50 | elfring | Note Added: 0006106 | |
| 2012-03-26 16:05 | lefessan | Note Added: 0007169 | |
| 2012-03-26 16:05 | lefessan | Assigned To | => lefessan |
| 2012-03-26 16:05 | lefessan | Status | new => acknowledged |
| 2012-03-26 16:21 | elfring | Note Added: 0007172 | |
| 2012-07-06 16:22 | doligez | Target Version | => 4.01.0+dev |
| 2012-07-31 13:36 | doligez | Target Version | 4.01.0+dev => 4.00.1+dev |
| 2012-09-06 19:22 | frisch | Target Version | 4.00.1+dev => 4.00.2+dev |
| 2013-06-06 23:06 | frisch | Target Version | 4.00.2+dev => 4.01.0+dev |
| Copyright © 2000 - 2011 MantisBT Group |