0005383: Cannot build OCaml 3.12.1 Win32/MSVC

(0006435)
protz (manager)
2011-12-21 11:39

Hi,

Thanks for reporting this. Can you provide any explanation as to why this is failing now?
- Is it a Makefile issue (wrong compilation order)?
- Is it something else?

I'm not familiar with MSVC but it seems weird that we should be defining something private (starting with _).

Thanks,

jonathan

(0006441)
avlasov (reporter)
2011-12-21 12:44

Defining _WIN32_WINNT is a standard Microsoft way to specify the minimum system required.
In this case, for TryEnterCritcalSection the minimum version required is Windows 2000, so one should define _WIN32_WINNT as 0x0400 or later.
See http://msdn.microsoft.com/en-us/library/windows/desktop/ms686857%28v=vs.85%29.aspx [^] for details.

Actually, another file in OCaml 3.12.1 source code otherlibs\win32unix\winworker.h already defines _WIN32_WINNT as 0x0400.

If the appropriate _WIN32_WINNT version is not defined, then compiling files referencing TryEnterCriticalSection should normally fail, since it is not in the original WIN32, but was added later.

(0006442)
protz (manager)
2011-12-21 14:05

That's a good justification, thanks :-). Could you possibly submit a patch against latest HEAD, using diff --git?

Cheers,

jonathan

(0006739)
xleroy (administrator)
2012-01-19 20:30

To be fixed as suggested by the reporter. Thanks.

(0006845)
protz (manager)
2012-01-30 16:23

Fixed in r12100 (trunk) and r12101 (version/3.12).

Issue History
Date Modified	Username	Field	Change
2011-10-24 07:25	avlasov	New Issue
2011-12-21 11:39	protz	Note Added: 0006435
2011-12-21 12:44	avlasov	Note Added: 0006441
2011-12-21 14:05	protz	Note Added: 0006442
2012-01-19 20:30	xleroy	Note Added: 0006739
2012-01-19 20:30	xleroy	Status	new => confirmed
2012-01-30 16:23	protz	Note Added: 0006845
2012-01-30 16:23	protz	Status	confirmed => resolved
2012-01-30 16:23	protz	Fixed in Version	=> 3.13.0+dev
2012-01-30 16:23	protz	Resolution	open => fixed
2012-01-30 16:23	protz	Assigned To	=> protz

Notes
(0006435) protz (manager) 2011-12-21 11:39	Hi, Thanks for reporting this. Can you provide any explanation as to why this is failing now? - Is it a Makefile issue (wrong compilation order)? - Is it something else? I'm not familiar with MSVC but it seems weird that we should be defining something private (starting with _). Thanks, jonathan

(0006441) avlasov (reporter) 2011-12-21 12:44	Defining _WIN32_WINNT is a standard Microsoft way to specify the minimum system required. In this case, for TryEnterCritcalSection the minimum version required is Windows 2000, so one should define _WIN32_WINNT as 0x0400 or later. See http://msdn.microsoft.com/en-us/library/windows/desktop/ms686857%28v=vs.85%29.aspx [^] for details. Actually, another file in OCaml 3.12.1 source code otherlibs\win32unix\winworker.h already defines _WIN32_WINNT as 0x0400. If the appropriate _WIN32_WINNT version is not defined, then compiling files referencing TryEnterCriticalSection should normally fail, since it is not in the original WIN32, but was added later.

(0006442) protz (manager) 2011-12-21 14:05	That's a good justification, thanks :-). Could you possibly submit a patch against latest HEAD, using diff --git? Cheers, jonathan

(0006739) xleroy (administrator) 2012-01-19 20:30	To be fixed as suggested by the reporter. Thanks.

(0006845) protz (manager) 2012-01-30 16:23	Fixed in r12100 (trunk) and r12101 (version/3.12).

Relationships