Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour of flatten_fields and various functions in presence of object indexes. #5428

Closed
vicuna opened this issue Dec 15, 2011 · 4 comments · Fixed by #9567
Closed

Behaviour of flatten_fields and various functions in presence of object indexes. #5428

vicuna opened this issue Dec 15, 2011 · 4 comments · Fixed by #9567

Comments

@vicuna
Copy link

vicuna commented Dec 15, 2011

Original bug ID: 5428
Reporter: @garrigue
Assigned to: @garrigue
Status: assigned (set by @garrigue on 2011-12-15T02:38:31Z)
Resolution: open
Priority: normal
Severity: feature
Version: 3.13.0+dev
Target version: later
Category: typing
Tags: typing, gadts
Parent of: #5425 #5427

Bug description

Due to the introduction of object indexes for GADTs, the row variable of an object may now be an expansible type abbreviation.
A first consequence is that flatten_fields will not completely flatten the object, since the type abbreviation will not be expanded (flatten_fields does not receive the current environment).
Another consequence is that various functions may be called with the expansion of this type abbreviation, which is a Tfield, e.g. during printing.
Concrete problems have been fixed, but new bugs may appear in the future.
(Test cases were added to typing-gadts/test.ml)

@vicuna
Copy link
Author

vicuna commented Dec 2, 2015

Comment author: @alainfrisch

Jacques: I would suggest to close this ticket and open new ones when actual bugs are found. Or do you prefer to keep it open as a reminder to review the code?

@vicuna
Copy link
Author

vicuna commented Dec 3, 2015

Comment author: @garrigue

Let's just keep it for later. It may be good as an anchor if a new bug appears. But it shouldn't be given a target version, because that doesn't make sense.

@vicuna
Copy link
Author

vicuna commented Mar 14, 2017

Comment author: @garrigue

This is not a bug per se, just an anchor.

@github-actions
Copy link

This issue has been open one year with no activity. Consequently, it is being marked with the "stale" label. What this means is that the issue will be automatically closed in 30 days unless more comments are added or the "stale" label is removed. Comments that provide new information on the issue are especially welcome: is it still reproducible? did it appear in other contexts? how critical is it? etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants