0005475: Wrapper script for interpreted LablTk wrongly handles command line parameters

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0005475

OCaml

OCaml general

public

2012-01-13 17:21

2012-01-17 22:49

Reporter

nodakai

Assigned To

lefessan

Priority

low

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

3.13.0+dev

Target Version

Fixed in Version

3.13.0+dev

Summary

0005475: Wrapper script for interpreted LablTk wrongly handles command line parameters

Description

I found a problematic code in the wrapper shell script for interpreted LablTk.

$ cat `which labltk`
#!/bin/sh
exec /home/nodakai/ocaml/lib/ocaml/labltk/labltktop -I /home/nodakai/ocaml/lib/ocaml/labltk $*

Here, the last $* should be "$@" according to sh specification.
http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html [^]

Currently it cannot accept an argument containing spaces.

Steps To Reproduce

$ cat labltk_space.ml
let main argv =
    let top = Tk.openTk () in
    Wm.title_set top argv.(1);
    Tk.mainLoop ()
;; main Sys.argv

$ labltk labltk_space.ml "10 20"
+---------+
[ 10 ]
+---------+
| |
| |
+---------+

Additional Information

A natively compiled version doesn't suffer from the above problem

$ ocamlopt.opt -I +labltk labltk.cmxa labltk_space.ml -o labltk_space.exe
$ ./labltk_space.exe "10 20"
+---------+
[ 10 20 ]
+---------+
| |
| |
+---------+

This problem is also in trunk

http://caml.inria.fr/cgi-bin/viewvc.cgi/ocaml/trunk/otherlibs/labltk/lib/Makefile?revision=HEAD&view=markup [^]

I attached a patch for trunk.

Tags

No tags attached.

Attached Files

labltk.patch [^] (567 bytes) 2012-01-13 17:21 [Show Content] [Hide Content]

Index: otherlibs/labltk/lib/Makefile
===================================================================
--- otherlibs/labltk/lib/Makefile       (revision 12019)
+++ otherlibs/labltk/lib/Makefile       (working copy)
@@ -71,7 +71,7 @@
 $(LIBNAME): Makefile $(TOPDIR)/config/Makefile
        @echo Generate $@
        @echo "#!/bin/sh" > $@
-       @echo 'exec $(INSTALLDIR)/$(LIBNAME)top$(EXE) -I $(INSTALLDIR) $$*' >> $@
+       @echo 'exec $(INSTALLDIR)/$(LIBNAME)top$(EXE) -I $(INSTALLDIR) "$$@"' >> $@

 install-script: $(LIBNAME)
        cp $(LIBNAME) $(BINDIR)

Relationships

Notes
(0006706) lefessan (developer) 2012-01-17 22:49	I applied the patch, tested it, and also modified myocamlbuild.ml that tries to generate the same file (commit r12032 in SVN trunk).

Issue History
Date Modified	Username	Field	Change
2012-01-13 17:21	nodakai	New Issue
2012-01-13 17:21	nodakai	File Added: labltk.patch
2012-01-17 22:49	lefessan	Note Added: 0006706
2012-01-17 22:49	lefessan	Status	new => resolved
2012-01-17 22:49	lefessan	Fixed in Version	=> 3.13.0+dev
2012-01-17 22:49	lefessan	Resolution	open => fixed
2012-01-17 22:49	lefessan	Assigned To	=> lefessan