Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsuite does not check camlp4o compatibility #5492

Closed
vicuna opened this issue Jan 23, 2012 · 2 comments
Closed

testsuite does not check camlp4o compatibility #5492

vicuna opened this issue Jan 23, 2012 · 2 comments

Comments

@vicuna
Copy link

vicuna commented Jan 23, 2012

Original bug ID: 5492
Reporter: @lefessan
Status: closed (set by @diml on 2016-12-07T17:27:35Z)
Resolution: open
Priority: normal
Severity: feature
Version: 3.13.0+dev
Category: -for Camlp4 use https://github.com/ocaml/camlp4/issues
Tags: patch
Monitored by: @xclerc

Bug description

Since any new construct in the language should be tested in the testsuite/, we should always verify that camlp4o generates correct code for these new constructs, to be sure that a new release is not shipped with no support for some new construct in camlp4o.

A patch to the testsuite/ makefile is provided.

File attachments

@vicuna
Copy link
Author

vicuna commented Mar 14, 2012

Comment author: @xavierleroy

The patch looks very incomplete to me, as it applies only to tests of the "several" kind.

It might be worthwhile to have a way to run the testsuite using camlp4o, but I wouldn't want this to be done at every run of the testsuite. One reason is that we need to be able to test new features before camlp4 is updated to support them. Another reason is that several of us developers configure with -no-camlp4 to speed up compiles during development.

@vicuna
Copy link
Author

vicuna commented Dec 7, 2016

Comment author: @diml

Camlp4 is now a separate project. Please re-open a ticket on github [1] if you are still interested in seeing the original issue fixed.

[1] https://github.com/ocaml/camlp4/issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant