0005504: Please consider stopping using keyword substitutions

From 2a96099674565c5da308dd0ddd35c39d9bb6a0f0 Mon Sep 17 00:00:00 2001 From: Stephane Glondu <steph@glondu.net> Date: Fri, 10 Feb 2012 11:51:05 +0100 Subject: [PATCH] Reset svn keywords --- config/auto-aux/expm1.c | 2 +- otherlibs/systhreads/st_posix.h | 2 +- otherlibs/systhreads/st_stubs.c | 2 +- otherlibs/systhreads/st_win32.h | 2 +- otherlibs/systhreads/thread.ml | 2 +- otherlibs/systhreads/threads.h | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/config/auto-aux/expm1.c b/config/auto-aux/expm1.c index ec31587..be41d02 100644 --- a/config/auto-aux/expm1.c +++ b/config/auto-aux/expm1.c @@ -11,7 +11,7 @@ /* */ /***********************************************************************/ -/* $Id: longlong.c 4833 2002-05-25 08:33:26Z xleroy $ */ +/* $Id$ */ #include <math.h> diff --git a/otherlibs/systhreads/st_posix.h b/otherlibs/systhreads/st_posix.h index 5f9592d..708a4ab 100644 --- a/otherlibs/systhreads/st_posix.h +++ b/otherlibs/systhreads/st_posix.h @@ -11,7 +11,7 @@ /* */ /***********************************************************************/ -/* $Id: posix.c 9270 2009-05-20 11:52:42Z doligez $ */ +/* $Id$ */ /* POSIX thread implementation of the "st" interface */ diff --git a/otherlibs/systhreads/st_stubs.c b/otherlibs/systhreads/st_stubs.c index 7b97a50..61d1842 100644 --- a/otherlibs/systhreads/st_stubs.c +++ b/otherlibs/systhreads/st_stubs.c @@ -11,7 +11,7 @@ /* */ /***********************************************************************/ -/* $Id: posix.c 9270 2009-05-20 11:52:42Z doligez $ */ +/* $Id$ */ #include "alloc.h" #include "backtrace.h" diff --git a/otherlibs/systhreads/st_win32.h b/otherlibs/systhreads/st_win32.h index 2b9041d..29f0337 100644 --- a/otherlibs/systhreads/st_win32.h +++ b/otherlibs/systhreads/st_win32.h @@ -11,7 +11,7 @@ /* */ /***********************************************************************/ -/* $Id: posix.c 9270 2009-05-20 11:52:42Z doligez $ */ +/* $Id$ */ /* Win32 implementation of the "st" interface */ diff --git a/otherlibs/systhreads/thread.ml b/otherlibs/systhreads/thread.ml index 18cc819..b0f01da 100644 --- a/otherlibs/systhreads/thread.ml +++ b/otherlibs/systhreads/thread.ml @@ -11,7 +11,7 @@ (* *) (***********************************************************************) -(* $Id: thread_posix.ml 9547 2010-01-22 12:48:24Z doligez $ *) +(* $Id$ *) (* User-level threads *) diff --git a/otherlibs/systhreads/threads.h b/otherlibs/systhreads/threads.h index 7466242..3675e69 100644 --- a/otherlibs/systhreads/threads.h +++ b/otherlibs/systhreads/threads.h @@ -11,7 +11,7 @@ /* */ /***********************************************************************/ -/* $Id: posix.c 9270 2009-05-20 11:52:42Z doligez $ */ +/* $Id$ */ #ifndef CAML_THREADS_H #define CAML_THREADS_H -- 1.7.9

Notes
(0006941) meyer (developer) 2012-02-19 18:32	Thanks for reporting that. Similar patch applied with SVN r12170.

(0006944) frisch (developer) 2012-02-19 19:38 edited on: 2012-02-19 19:39	My understanding was that the attached diff is an example of a diff cluttered by keyword expansions, not a patch to be applied. The solution would rather be to remove all the lines with SVN keywords from the sources. Stéphane: is it indeed what you mean?

(0006945) meyer (developer) 2012-02-19 20:40	Yes, probably my misunderstanding, as the keywords don't get expanded in git. So, yes, I understood that the patch is just an example, and we should remove all the $Id$ instead, however I observed that they don't get expanded anyway, in my git svn repo, so I just replaced the ones that were comited by incident. I was just about to send the e-mail to the mailing list with the query what shall we do with it, as the keyword expansions is pretty useless now days.

(0006946) glondu (reporter) 2012-02-19 21:13	> Stéphane: is it indeed what you mean? It is indeed. > I observed that they don't get expanded anyway, in my git svn repo I use git-svn too. But keywords are expanded in the tarballs that are released, and this is what I'm complaining about.

Issue History
Date Modified	Username	Field	Change
2012-02-10 11:54	glondu	New Issue
2012-02-10 11:54	glondu	File Added: 0001-Reset-svn-keywords.patch
2012-02-15 08:56	gasche	Status	new => confirmed
2012-02-19 18:20	meyer	Assigned To	=> meyer
2012-02-19 18:20	meyer	Status	confirmed => assigned
2012-02-19 18:32	meyer	Note Added: 0006941
2012-02-19 18:32	meyer	Status	assigned => resolved
2012-02-19 18:32	meyer	Fixed in Version	=> 3.13.0+dev
2012-02-19 18:32	meyer	Resolution	open => fixed
2012-02-19 19:38	frisch	Note Added: 0006944
2012-02-19 19:39	frisch	Note Edited: 0006944	View Revisions
2012-02-19 20:40	meyer	Note Added: 0006945
2012-02-19 21:13	glondu	Note Added: 0006946

Relationships