Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0005504OCamlOCaml generalpublic2012-02-10 11:542013-08-31 12:46
Reporterglondu 
Assigned Tomeyer 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version3.13.0+dev 
Summary0005504: Please consider stopping using keyword substitutions
DescriptionThey uselessly clutter diffs against release tarballs, making reviewing more difficult for almost no benefit.

They can also lead to errors such as committing unwanted changes. See the attached patch (against 3.12 branch) for an example.
TagsNo tags attached.
Attached Filespatch file icon 0001-Reset-svn-keywords.patch [^] (3,283 bytes) 2012-02-10 11:54 [Show Content]

- Relationships

-  Notes
(0006941)
meyer (developer)
2012-02-19 18:32

Thanks for reporting that. Similar patch applied with SVN r12170.
(0006944)
frisch (developer)
2012-02-19 19:38
edited on: 2012-02-19 19:39

My understanding was that the attached diff is an example of a diff cluttered by keyword expansions, not a patch to be applied. The solution would rather be to remove all the lines with SVN keywords from the sources. St├ęphane: is it indeed what you mean?

(0006945)
meyer (developer)
2012-02-19 20:40

Yes, probably my misunderstanding, as the keywords don't get expanded in git. So, yes, I understood that the patch is just an example, and we should remove all the $Id$ instead, however I observed that they don't get expanded anyway, in my git svn repo, so I just replaced the ones that were comited by incident. I was just about to send the e-mail to the mailing list with the query what shall we do with it, as the keyword expansions is pretty useless now days.
(0006946)
glondu (reporter)
2012-02-19 21:13

> St├ęphane: is it indeed what you mean?

It is indeed.

> I observed that they don't get expanded anyway, in my git svn repo

I use git-svn too. But keywords are expanded in the tarballs that are released, and this is what I'm complaining about.

- Issue History
Date Modified Username Field Change
2012-02-10 11:54 glondu New Issue
2012-02-10 11:54 glondu File Added: 0001-Reset-svn-keywords.patch
2012-02-15 08:56 gasche Status new => confirmed
2012-02-19 18:20 meyer Assigned To => meyer
2012-02-19 18:20 meyer Status confirmed => assigned
2012-02-19 18:32 meyer Note Added: 0006941
2012-02-19 18:32 meyer Status assigned => resolved
2012-02-19 18:32 meyer Fixed in Version => 3.13.0+dev
2012-02-19 18:32 meyer Resolution open => fixed
2012-02-19 19:38 frisch Note Added: 0006944
2012-02-19 19:39 frisch Note Edited: 0006944 View Revisions
2012-02-19 20:40 meyer Note Added: 0006945
2012-02-19 21:13 glondu Note Added: 0006946
2013-08-31 12:46 xleroy Status resolved => closed


Copyright © 2000 - 2011 MantisBT Group
Powered by Mantis Bugtracker