Please backport test suite fixes to the 3.12 branch #5512
Comments
|
Comment author: meyer Hello Stephane, The patch submitted does not apply to current 3.12 tree. From your description I am not clear if you want the patch to be applied to the trunk and the listed commits back-ported to 3.12, or you want this patch to be applied to 3.12 along with the commits. Could you please clarify or possibly port the patch and I will do the rest. Wojciech |
|
Comment author: @glondu Some commits indeed need some porting, but they are all available at the address I gave: http://patch-tracker.debian.org/package/ocaml/3.12.2~~dev6+12112-2 (patches 15-26). The base is slightly different, but they apply (with patch) to the current 3.12 branch. For your convenience, I've attached a rebased branch over revision 12161. |
|
Comment author: @glondu ... And I'd also like the new patch to be applied to the trunk. |
|
Comment author: @glondu I've uploaded an updated patch queue (that applies to r12185), with the following changes:
|
|
Comment author: meyer Sorry it was taking that long. I applied the trunk patch only - slightly modified - (r12216) as the 3.12.* is now closed. Is there are anything else I can do for you about this PR? Cheers, |
|
Comment author: @glondu The patch applied is not the right one... |
|
Comment author: @glondu I've attached a new patch to be applied to the trunk. |
|
Comment author: @glondu The issue fixed by my last patch has been fixed differently (in a less elegant way, IMHO) in revision 12239. I'm not sure if this was intentional, but I guess this bug can be closed now. |
Original bug ID: 5512
Reporter: @glondu
Assigned to: meyer
Status: closed (set by meyer on 2012-04-08T02:43:13Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 3.12.1
Fixed in version: 4.00.0+dev
Category: ~DO NOT USE (was: OCaml general)
Monitored by: mehdi
Bug description
Hello,
Please backport the following SVN commits to the 3.12 branch:
11089, 11090, 11095, 11131, 11132, 11135, 11136, 10663, 11965, 12041, 12054
and the attached patch (already submitted in #5199). I believe these are needed for running the test suite on bytecode-only architectures.
As far as my running the test suite in Debian goes, I uploaded a snapshot of the 3.12 branch to experimental (revision 12112), with the multiple compilation approach (cf #5483). It failed on architectures with no native code compiler (which was kind of expected) and, strangely, on kfreebsd-* as well. Even when the build is successful, some tests fail, though. I applied the aforementioned patches (you can see the patches applied at [3], the one referred to in this report are 15-26) and the package compiles on more architectures [2], which is a big improvement even though some failures still remain.
[1] https://buildd.debian.org/status/logs.php?pkg=ocaml&ver=3.12.2~~dev6%2B12112-1
[2] https://buildd.debian.org/status/logs.php?pkg=ocaml&ver=3.12.2~~dev6%2B12112-2
[3] http://patch-tracker.debian.org/package/ocaml/3.12.2~~dev6+12112-2
Cheers,
--
Stéphane
File attachments
The text was updated successfully, but these errors were encountered: