Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share more between Unix and Windows makefiles #5556

Closed
vicuna opened this issue Mar 27, 2012 · 2 comments
Closed

Share more between Unix and Windows makefiles #5556

vicuna opened this issue Mar 27, 2012 · 2 comments

Comments

@vicuna
Copy link

vicuna commented Mar 27, 2012

Original bug ID: 5556
Reporter: @alainfrisch
Status: resolved (set by @xavierleroy on 2012-03-27T08:41:26Z)
Resolution: suspended
Priority: normal
Severity: minor
Category: configure and build/install
Monitored by: @jmeber

Bug description

In many directories of OCaml sources, Makefile and Makefile.nt share a lot of common code (through inclusion of a Makefile.shared). This avoids a lot of duplication and facilitates the task of maintaining the build system up to date for Windows. I propose to continue this effort. In particular, the root Makefile(s) could be largely shared as well.

@vicuna
Copy link
Author

vicuna commented Mar 27, 2012

Comment author: @xavierleroy

This is not a problem report per se, and I feel that using the bug tracker this way diminishes its efficiency, making it harder to spot the real problem reports.

As to the Makefiles: yes, they could be refactored, but 1- it's boring work with high breakage potential, and 2- to do a good job at it, we'd need to switch all makefiles to GNU make (instead of hacking around the limitations of POSIX make), a move that I'd welcome but that some other developers oppose.

@vicuna vicuna closed this as completed Mar 27, 2012
@vicuna
Copy link
Author

vicuna commented Mar 27, 2012

Comment author: @alainfrisch

As to the Makefiles: yes, they could be refactored, but 1- it's boring work with high breakage potential, and 2- to do a good job at it, we'd need to switch all makefiles to GNU make (instead of hacking around the limitations of POSIX make), a move that I'd welcome but that some other developers oppose.

I'm not proposing to completely merge Makefiles, just to factorize common code, as already done e.g. in stdlib, byterun, otherlibs. I don't think we need to switch to GNU make to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant