Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0005648OCamlOCaml generalpublic2012-06-13 15:482012-09-02 02:32
Reporterglondu 
Assigned Tomeyer 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version4.00.1+devFixed in Version 
Summary0005648: Some tests are failing in 4.00.0+beta2
DescriptionThe following tests fail on my machine (amd64, Debian unstable):

  - lib-marshal: Uncaught exception: Invalid_argument("output_value: abstract value (outside heap)")
  - lib-threads/test1.ml: Files test1.reference and - are different
  - lib-threads/test4.ml: doesn't seem to terminate
  - lib-threads/testexit.ml: Files testexit.reference and - are different
TagsNo tags attached.
Attached Filespatch file icon libmarshal-test-fix.patch [^] (364 bytes) 2012-06-18 23:10 [Show Content]
patch file icon test-threads.patch [^] (2,187 bytes) 2012-07-17 09:40 [Show Content]

- Relationships

-  Notes
(0007566)
meyer (developer)
2012-06-18 22:10

Hi,

Thanks.

I don't have an access to X86_64 right now, could you specify which test has failed in lib-marshal, that would help me at least assess the severity.

Wojciech
(0007569)
meyer (developer)
2012-06-18 23:11

Can you apply the patch against trunk attached and see if that fixes the problem?
(0007571)
meyer (developer)
2012-06-18 23:27

Can't reproduce it on my 64 bit host - without patch
(0007575)
meyer (developer)
2012-06-18 23:53
edited on: 2012-06-18 23:54

Hmm, looking at my patch now, I feel it's incorrect. The recursive closures will not be marshaled correctly when they are stored in a block, precisely the rest of the block after the closure will not be marshaled. So feel free to try out the patch but I don't think I can apply it.

(0007577)
glondu (reporter)
2012-06-19 09:54

I've just noticed that the lib-marshal test uses -custom. Its failure is Debian-specific (we have a special handling to avoid the strippability issue). Sorry for the noise.

However, the lib-threads tests fail even with pristine ocaml sources.
(0007613)
doligez (administrator)
2012-06-26 18:14

Non-determinism in the thread semantics makes it difficult to produce a reliable test suite for threads. This needs work.
(0007644)
doligez (administrator)
2012-07-06 15:49

I'd like to see the files:
  testsuite/tests/lib-threads/test1.result
  testsuite/tests/lib-threads/test4.result (if it exists)
  testsuite/tests/lib-threads/testexit.result

Could you please upload them here?
(0007762)
doligez (administrator)
2012-07-17 09:39

I found and fixed an i18n bug that probably explains your test failures. (commit 12717 in 4.00, patch included here).

If you could re-test with this patch, that would be great.
(0007791)
glondu (reporter)
2012-07-21 14:21

Indeed, you're right. All the tests pass with the patch.
(0007996)
meyer (developer)
2012-09-02 02:32

Closing, reported problem has been solved

- Issue History
Date Modified Username Field Change
2012-06-13 15:48 glondu New Issue
2012-06-18 22:10 meyer Note Added: 0007566
2012-06-18 23:10 meyer File Added: libmarshal-test-fix.patch
2012-06-18 23:11 meyer Note Added: 0007569
2012-06-18 23:27 meyer Note Added: 0007571
2012-06-18 23:53 meyer Note Added: 0007575
2012-06-18 23:54 meyer Note Edited: 0007575 View Revisions
2012-06-19 09:54 glondu Note Added: 0007577
2012-06-26 18:14 doligez Note Added: 0007613
2012-06-26 18:14 doligez Status new => confirmed
2012-07-04 17:17 doligez Target Version => 4.00.0+dev
2012-07-06 03:41 meyer Assigned To => meyer
2012-07-06 03:41 meyer Status confirmed => assigned
2012-07-06 15:49 doligez Note Added: 0007644
2012-07-06 15:49 doligez Status assigned => feedback
2012-07-11 15:47 doligez Target Version 4.00.0+dev => 4.01.0+dev
2012-07-17 09:39 doligez Note Added: 0007762
2012-07-17 09:40 doligez File Added: test-threads.patch
2012-07-21 14:21 glondu Note Added: 0007791
2012-07-21 14:21 glondu Status feedback => assigned
2012-07-31 13:36 doligez Target Version 4.01.0+dev => 4.00.1+dev
2012-09-02 02:32 meyer Note Added: 0007996
2012-09-02 02:32 meyer Status assigned => closed
2012-09-02 02:32 meyer Resolution open => fixed


Copyright © 2000 - 2011 MantisBT Group
Powered by Mantis Bugtracker