byterun/startup.c lacks code checksum initialization #5660
Comments
|
Comment author: @alainfrisch Thanks, well spotted! However, caml_code_md5 does not seem to be used any more (trunk and 4.00 branches). Cf this commit: http://caml.inria.fr/cgi-bin/viewvc.cgi?view=revision&revision=12229 Can you check if the problem is still present on those branches (and if so, maybe update your patch)? Alain |
|
Comment author: @xavierleroy After reviewing the new code checksumming infrastructure introduced by commit 12229, I am pretty sure the issue is already fixed in 4.00.0 and in trunk. I'm marking this PR as resolved; feel free to reopen if the problem is still there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Original bug ID: 5660
Reporter: @db4
Status: closed (set by @xavierleroy on 2015-07-24T08:39:05Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 3.12.1
Fixed in version: 4.00.0
Category: runtime system and C interface
Bug description
It's needed for Marshal.Closures to be safe. Without is Marshal.from_* functions just crash instead of raising (Failure "input_value: code mismatch") if the code is changed.
The patch is attached.
File attachments
The text was updated successfully, but these errors were encountered: