0005662: typo in md5.c

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0005662

OCaml

OCaml runtime system

public

2012-06-25 14:36

2012-06-25 18:00

Reporter

oandrieu

Assigned To

lefessan

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

4.01.0+dev

Summary

0005662: typo in md5.c

Description

The caml_MD5Final function ends with the following line:

memset(ctx, 0, sizeof(ctx)); /* In case it's sensitive */

The intent is to wipe the MD5 context (it contains a few bytes of the data being hashed). But since ctx is a pointer, this only wipes the first 4 or 8 bytes of the context.

Should be:

memset(ctx, 0, sizeof *ctx); /* In case it's sensitive */

Tags

No tags attached.

Attached Files

Relationships

Notes
(0007607) lefessan (developer) 2012-06-25 18:00	Fixed in SVN trunk revision 12642 for 4.01.

Issue History
Date Modified	Username	Field	Change
2012-06-25 14:36	oandrieu	New Issue
2012-06-25 18:00	lefessan	Note Added: 0007607
2012-06-25 18:00	lefessan	Status	new => resolved
2012-06-25 18:00	lefessan	Fixed in Version	=> 4.01.0+dev
2012-06-25 18:00	lefessan	Resolution	open => fixed
2012-06-25 18:00	lefessan	Assigned To	=> lefessan