0005682: In Typemod.type_implementation: cmt file is created in case of typing error, even in print_types or dont_write_files mode

Notes
(0007737) lefessan (developer) 2012-07-12 17:04	Have you found a .cmt file generated when it should not be, or are you just reviewing the code ? Cmt_format.save_cmt checks that - Clflags.binary_annotations is true (ocamldoc should never set that flag to true, and ocamldoc is the only user of Clflags.dont_write_files from the comments in Clflags) - Clflags.print_types is false

(0007738) frisch (developer) 2012-07-12 17:16	Just reviewing the code. Maybe dont_write_files should be checked as well, I'm not sure (it's used by ocamldoc).

(0007739) lefessan (developer) 2012-07-12 17:30	Since the typer is now shipped into compilerlibs, some other people might make a weird usage of Clflags.dont_write_files, so I just added the test in cmt_format, although you would have to be crazy to both activate Clflags.binary_annotations and Clflags.dont_write_files.

Relationships