Mantis Bug Tracker

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0005682OCamlOCaml generalpublic2012-07-12 16:492012-07-12 17:30
Reporterfrisch 
Assigned Tolefessan 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version4.00.0+devFixed in Version4.00.0+dev 
Summary0005682: In Typemod.type_implementation: cmt file is created in case of typing error, even in print_types or dont_write_files mode
DescriptionI believe the the final catch-all handler should not call save_cmt when either print_types or dont_write_files is true.
TagsNo tags attached.
Attached Files

- Relationships

-  Notes
(0007737)
lefessan (developer)
2012-07-12 17:04

Have you found a .cmt file generated when it should not be, or are you just reviewing the code ?

Cmt_format.save_cmt checks that
- Clflags.binary_annotations is true (ocamldoc should never set that flag to true, and ocamldoc is the only user of Clflags.dont_write_files from the comments in Clflags)
- Clflags.print_types is false
(0007738)
frisch (developer)
2012-07-12 17:16

Just reviewing the code. Maybe dont_write_files should be checked as well, I'm not sure (it's used by ocamldoc).
(0007739)
lefessan (developer)
2012-07-12 17:30

Since the typer is now shipped into compilerlibs, some other people might make a weird usage of Clflags.dont_write_files, so I just added the test in cmt_format, although you would have to be crazy to both activate Clflags.binary_annotations and Clflags.dont_write_files.

- Issue History
Date Modified Username Field Change
2012-07-12 16:49 frisch New Issue
2012-07-12 16:49 frisch Status new => assigned
2012-07-12 16:49 frisch Assigned To => lefessan
2012-07-12 17:04 lefessan Note Added: 0007737
2012-07-12 17:16 frisch Note Added: 0007738
2012-07-12 17:30 lefessan Note Added: 0007739
2012-07-12 17:30 lefessan Status assigned => resolved
2012-07-12 17:30 lefessan Fixed in Version => 4.00.0+dev
2012-07-12 17:30 lefessan Resolution open => fixed


Copyright © 2000 - 2011 MantisBT Group
Powered by Mantis Bugtracker